Fwd: Revision control support in Dolphin/Konqueror
Jonas Bähr
any one interested in taking a look at this? It could give an
interesting addition to Krusader too, and as far as I know we already
use libkonq for the service menus anyway.
bye,
Jonas
Anfang der weitergeleiteten E-Mail:
> Von: Peter Penz <peter...@gmx.at>
> Datum: 25. August 2009 20:31:58 MESZ
> An: kfm-...@kde.org
> Betreff: Re: Revision control support in Dolphin/Konqueror
> Antwort an: kfm-...@kde.org
>
> Hi,
>
> I've attached an updated patch for version control support in
> Dolphin/Konqueror. There is a related discussion ongoing on kdevelop-
> devel
> (see https://barney.cs.uni-potsdam.de/mailman/private/kdevelop-devel/2009-
> August/034635.html), but no matter where the version control plugins
> will get
> located and how much code is shared [1], the plugin interface must
> be moved
> outside of Dolphin first.
>
> If there are no objections, I'd commit the classes
> KVersionControlPlugin.h
> KVersionControlPlugin.cpp
> into kdebase/apps/lib/konq on Monday the 31th of September (more
> details are
> given in the old e-mail below).
>
> Best regards,
> Peter
>
> [1] currently it looks like KDE/kdevplatform/plugins might be a proper
> location
>
> On Saturday, 25. July 2009 22:47:49 Peter Penz wrote:
>> Hello,
>>
>> I have added a revision control support into Dolphin/Konqueror that
>> works
>> with each view mode (the working version has not been committed
>> yet, will
>> be done on Monday). "Revision control support" in the scope of
>> Dolphin
>> means that the revision state of a file is indicated by an emblem
>> above the
>> icon and that context dependent revision control actions are
>> provided in
>> the context menu.
>>
>> For testing purposes I temporary implemented a Subversion plugin
>> inside
>> Dolphin (part of dolphin/src/revisioncontrolplugin.*), but for sure
>> this
>> plugin should be moved outside of Dolphin ASAP.
>>
>> I'd like to move this plugin into the kdesdk module, but before
>> this I'd
>> need to move the revision control base class from Dolphin into
>> kdebase/apps/lib/konq as
>> krevisioncontrolplugin.h/krevisioncontrolplugin.cpp (see attached
>> patch).
>>
>> Are there any general concerns/suggestions regarding the interface
>> or the
>> method- and enum-names? Would it be OK if I commit this class this
>> Monday?
>>
>> Whom must I ask to get the OK to create a directory "revisioncontrol"
>> (suggestion) inside KDE/kdesdk? This directory would contain the
>> files:
>> subversionplugin.cpp
>> subversionplugin.h
>> subversionplugin.desktop
>>
>> and might get extended by other revision control plugins.
>>
>> Thanks!
>> Peter