[Patch]: Allow klish to try libbsdxml in addition to libexpat when libexpat or auto backend is selected

45 views
Skip to first unread message

Stanislav Galabov

unread,
Apr 2, 2013, 4:52:33 AM4/2/13
to klis...@googlegroups.com
Hi all,

FreeBSD, at least 8.0+, ships with libbsdxml.so in its base system, which, according to the libbsdxml(3) man page is:
"The libbsdxml library is a verbatim copy of the eXpat XML library version 2.0.1".

Seeing as klish can be build with expat as an XML backend now I thought it might be useful to FreeBSD users out there to be able to autodetect and build against libbsdxml too.

I've tried this and it works - klish builds fine and is able to parse the XML files under xml-examples/test using libbsdxml.
This also makes it easier to cross-compile (I've tried it for ARM) klish on FreeBSD.

I've attached a patch for this change and I'd be happy if you guys find it useful and include it in klish mainline.

Best wishes,
Stanislav
libbsdxml.diff

Stanislav Galabov

unread,
Apr 2, 2013, 10:30:31 AM4/2/13
to klis...@googlegroups.com
Actually, after thinking a little more about it, I am attaching a second version of the patch, which would only check for libbsdxml.so if the target system is FreeBSD.

Best wishes,
Stanislav
libbsdxml_v2.diff

serj.k...@gmail.com

unread,
Apr 3, 2013, 10:11:59 AM4/3/13
to klis...@googlegroups.com
I have applied your first patch with a little changes. Thanks. Please test it on FreeBSD. Git commit is 53073e25c43fefd8c59a9d4be95bdf74711c28db

I think it's no use to check for freebsd. Additionally AC_CANONICAL_TARGET has bad side effects while cross-compilation.



02.04.2013 18:30, Stanislav Galabov пишет:
--
You received this message because you are subscribed to the Google Groups "klish-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to klish-dev+...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Stanislav Galabov

unread,
Apr 3, 2013, 10:21:06 AM4/3/13
to klis...@googlegroups.com
Thanks, Serj, it configures, builds and runs fine with both libbsdxml and libexpat on FreeBSD.
I also tried cross-compiling for ARM and it went well too.

Best wishes,
Stanislav
Reply all
Reply to author
Forward
0 new messages