Niels Slot
unread,Nov 15, 2011, 2:47:51 PM11/15/11Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Burkhard Lück, Cies Breijs, Mauricio Piacentini, kdeedu-...@googlegroups.com
Hi Burkhard,
First of all, thanks :)
I had a look at the patch, some comments:
- Decimal and comma lines look OK
- getdirection return 0 when the turtle is pointing upwards. This matches the behavior of the direction command. A definition of zero is a good idea. If you like also include a reference to the direction command.
- mod command description looks OK
- I'm not sure about the changes to the examples. I think it was also fine the way it was. The point wasn't to let the user know that a value is larger or smaller then some other value, but to let the user know the a variable is smaller or larger. So printing that "$x" (and the not the value of $x) is smaller/larger, makes sense to me. But then again, I'm not sure. Cies, if you're reading this, input is welcome :)
I'm fine with you committing the decimal/comma and mod parts. And also the getdirection once it's changed. But leave the example changes out for now.
About the version.. I remember that Cies had some ideas about that a couple of years ago. I don't really care, the version of KDE SC is what counts.
Regards,
Niels
2011/11/15 Burkhard Lück
<lu...@hube-lueck.de>
Hallo KTurtle Devels,
reading about kturtle on b.k.o this morning I noticed, that the documentation
needs an update, diff with these changes attached:
1) 'ArgumentSeparator' and 'DecimalSeparator' are translatable, so added that
to the documentation.
2) added getdirection and mod commands. Definition of zero imho should be
added.
"The direction zero is vertical up" - is that ok
3) fixed some xamples to print the actual value of the variable.
Any comment, improvements, objections to commit?
Thanks.
Btw. kturtle in trunk has still version 0.8.1 beta, should be bumped imho.
--
Burkhard Lück