Google Groups Home
Help | Sign in
Message from discussion Test.Simple style questions
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Marvin Humphrey  
View profile
 More options Aug 21 2007, 9:38 pm
From: Marvin Humphrey <mar...@rectangular.com>
Date: Tue, 21 Aug 2007 18:38:35 -0700
Local: Tues, Aug 21 2007 9:38 pm
Subject: Test.Simple style questions
David,

What's the rationale behind the stylistic choice of naming some  
member vars using UpperCamelCase, e.g. this.TestResults?  It seems  
like an unusual decision, since UpperCamelCase is usually reserved  
for classes/packages/namespaces.  I'd have gone with lowerCamelCase,  
but perhaps there's a pattern I haven't caught on to.

Also, a heads-up: for the new Test.Builder.TestResult class, I intend  
to use get/set accessors everywhere.  Public member vars suck.  See  
below.

Marvin Humphrey
Rectangular Research
http://www.rectangular.com/

/usr/www/live/htdocs/junk/Test.Simple/ $ ack actual_ok
doc/pod/Test/Builder.pod
479:      actual_ok: did it literally say 'ok'?
493:"actual_ok" is a reflection of whether or not the test literally  
printed "ok"
523:and actual_ok is left C<null>.
530:      actual_ok: 0,      // in absolute terms, it failed

lib/Test/Builder.js
231:        result.actual_ok = test;
235:        result.actual_ok = false;
420:        actual_ok: true,
447:        actual_ok: false,
642:                actual_ok: null,

tests/details.js
10:    actual_ok: true,
20:    actual_ok: true,
32:     actual_ok: false,
43:    actual_ok: false,
53:    actual_ok: true,
65:    actual_ok: null,
77:    actual_ok: true,

/usr/www/live/htdocs/junk/Test.Simple/ $ ack actualOK
lib/Test/Harness.js
112:                    if (test.TestResults[i].actualOK) this.bonus++;

tests/harness.js
61:            actualOK: true,
68:            actualOK: true,
101:    actualOK: false,
128:mockTest.TestResults[2].actualOK = true;
152:mockTest.TestResults[2].actualOK = false;
206:    actualOK: false,
296:        actualOK: true,
303:        actualOK: true,


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google