[jquery-ui] r3433 committed - changed border workaround so the hover and active states simply have a...

[codesite...@google.com]

Revision: 3433
Author: scottjehl
Date: Mon Nov 9 09:12:26 2009
Log: changed border workaround so the hover and active states simply have a
negative 1px margin to offset the border additions.
http://code.google.com/p/jquery-ui/source/detail?r=3433

Modified:
/branches/dev/themes/base/ui.menu.css

=======================================
--- /branches/dev/themes/base/ui.menu.css Mon Nov 9 09:08:36 2009
+++ /branches/dev/themes/base/ui.menu.css Mon Nov 9 09:12:26 2009
@@ -19,12 +19,9 @@
display:block;
padding:.2em .4em;
line-height:1.5;
- border: 0;
zoom:1;
- margin: 1px;
-}
-.ui-menu .ui-menu-item a:hover,
-.ui-menu .ui-menu-item a.ui-state-hover {
+}
+.ui-menu .ui-menu-item a.ui-state-hover,
.ui-menu .ui-menu-item a.ui-state-active {
- margin: 0;
-}
+ margin: -1px;
+}

[Scott Jehl]

I did this workaround because I couldn't get the transparent border
(dashed) trick to work in IE6. This works well.

Currently, the rule to remove the margin uses TR classes:

.ui-menu .ui-menu-item a.ui-state-hover,
.ui-menu .ui-menu-item a.ui-state-active {

margin: -1px;
}

Should we make these widget-specific states? Generally, we don't write
widget styles against theme classes...

.ui-menu .ui-menu-item a.ui-menu-item-hover,
.ui-menu .ui-menu-item a.ui-menu-item-active {
margin: -1px;
}



On Nov 9, 2009, at 12:16 PM | Nov 9, 2009, codesite...@google.com
wrote:

[Richard D. Worth]

On Mon, Nov 9, 2009 at 12:19 PM, Scott Jehl <sc...@scottjehl.com> wrote:

I did this workaround because I couldn't get the transparent border
(dashed) trick to work in IE6. This works well.

Currently, the rule to remove the margin uses TR classes:

.ui-menu .ui-menu-item a.ui-state-hover,
.ui-menu .ui-menu-item a.ui-state-active {

       margin: -1px;
}

Should we make these widget-specific states? Generally, we don't write
widget styles against theme classes...

.ui-menu .ui-menu-item a.ui-menu-item-hover,
.ui-menu .ui-menu-item a.ui-menu-item-active {
       margin: -1px;
}

I'm ok with that.

- Richard

[Scott Jehl]

okay with....? :)

[Richard D. Worth]

Make them widget-specific states