Ticket #4631 Draggable: Fixed positions include wrong scroll offset in Safari 4

[Jörn Zaefferer]

The version check he provides as a pseudo-patch looks like it could be
enough to fix this: http://dev.jqueryui.com/ticket/4631
Can someone with some experience with Draggables take a look?

Jörn

[Scott González]

We should be using feature detection here, not browser version checks.  I've added a comment to the ticket.

[Jörn Zaefferer]

Whats the feature here, and how can we detect it?

Jörn

2009/7/9 Scott González <scott.g...@gmail.com>:

[Brandon Aaron]

You'll most likely have to reproduce the bug with minimal markup and
test for the expected result like the offset module in jQuery does.

--
Brandon Aaron

[Scott González]

The feature is whether fixed positioning works properly. We can detect
it by creating an element, setting the position, then checking to see
if we get the correct offset.

On Thursday, July 9, 2009, Jörn Zaefferer

[Paul Bakaus]

2009/7/10 Scott González <scott.g...@gmail.com>

The feature is whether fixed positioning works properly. We can detect
it by creating an element, setting the position, then checking to see
if we get the correct offset.

This should be part of jQuery core though.
 

On Thursday, July 9, 2009, Jörn Zaefferer

<joern.z...@googlemail.com> wrote:
>
> Whats the feature here, and how can we detect it?
>
> Jörn
>
> 2009/7/9 Scott González <scott.g...@gmail.com>:
>> We should be using feature detection here, not browser version checks.  I've
>> added a comment to the ticket.
>>
>>
>> On Thu, Jul 9, 2009 at 10:20 AM, Jörn Zaefferer
>> <joern.z...@googlemail.com> wrote:
>>>
>>> The version check he provides as a pseudo-patch looks like it could be
>>> enough to fix this: http://dev.jqueryui.com/ticket/4631
>>> Can someone with some experience with Draggables take a look?
>>>
>>> Jörn
>>>
>>>
>>
>>
>> >
>>
>
> >
>

--
Paul Bakaus
UI Architect @ smart.fm
--
http://paulbakaus.com
http://www.linkedin.com/in/paulbakaus

[Scott González]

On Thu, Jul 9, 2009 at 8:37 PM, Paul Bakaus <paul....@googlemail.com> wrote:

2009/7/10 Scott González <scott.g...@gmail.com>

The feature is whether fixed positioning works properly. We can detect
it by creating an element, setting the position, then checking to see
if we get the correct offset.

This should be part of jQuery core though.

It should be, but we can't control when jQuery core gets released.  We also can't require a new version of jQuery for the next version of jQuery UI just to fix a single bug that we can fix on our own.  Every time we try to compensate for a bug in core, we need to do so in a way that will work with the current version of jQuery and some future fixed version of jQuery (and then file a bug for core, including a patch if possible).  This is another reason why we need to do feature detection instead of browser checks.  If we use browser checks and the bug gets fixed in core, it will break our code; if we then take out our code for compensating, it'll still break our code for the previous version of jQuery.  If we detect whether or not the problem exists, it won't matter what combination of browser and jQuery version gets used, we'll still handle it properly.