Message from discussion
Closure-compiler Build Passes All Unit Tests
Received: by 10.50.163.97 with SMTP id yh1mr221946igb.3.1333506185086;
Tue, 03 Apr 2012 19:23:05 -0700 (PDT)
X-BeenThere: jquery-bugs-team@googlegroups.com
Received: by 10.50.57.163 with SMTP id j3ls11184458igq.1.canary; Tue, 03 Apr
2012 19:23:03 -0700 (PDT)
Received: by 10.50.214.102 with SMTP id nz6mr220669igc.4.1333506183196;
Tue, 03 Apr 2012 19:23:03 -0700 (PDT)
Received: by 10.50.214.102 with SMTP id nz6mr220668igc.4.1333506183185;
Tue, 03 Apr 2012 19:23:03 -0700 (PDT)
Return-Path: <jere...@gmail.com>
Received: from mail-ob0-f172.google.com (mail-ob0-f172.google.com [209.85.214.172])
by gmr-mx.google.com with ESMTPS id no9si238971igc.0.2012.04.03.19.23.03
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 03 Apr 2012 19:23:03 -0700 (PDT)
Received-SPF: pass (google.com: domain of jere...@gmail.com designates 209.85.214.172 as permitted sender) client-ip=209.85.214.172;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jere...@gmail.com designates 209.85.214.172 as permitted sender) smtp.mail=jere...@gmail.com; dkim=pass header...@gmail.com
Received: by mail-ob0-f172.google.com with SMTP id tb4so564759obb.31
for <jquery-bugs-team@googlegroups.com>; Tue, 03 Apr 2012 19:23:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20120113;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to
:content-type;
bh=p6Oy3F9oJBZby4us89V+VDOhJE0BeyuUs+xYoJI9qBY=;
b=Xcz2T88wXXan4aJNb9VkcjRA7eXwEPxzTUsPcASiKmnpMzDRW3c6mo3fLu+5ZiIhdu
oAMmf/j77opegM1sSPFAKO3BtCs/8JiJWdpLjRSdxYLoM+/k4FwUIpNany3YSXkf5ZrQ
1xjYtGMaO74a4zgUQeuarjU+Lbg93HkaD5122DaVqmTxXejgf5PcpimxD3fjIBh3o5Vc
KewshSOt16TES+B/KlzH8xa9tk7ZBy8siAMqyskEAFcye7dtqKDaZKF1d/icpA5/tRqL
+YzmXt7lfWy0nquVDaw240qnuSqLpZeEACujnkApjHZ9SmcDBbER3hQp8CZvCI3/QvSF
Xd1w==
Received: by 10.182.111.3 with SMTP id ie3mr22327833obb.14.1333506182922; Tue,
03 Apr 2012 19:23:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.182.160.33 with HTTP; Tue, 3 Apr 2012 19:22:42 -0700 (PDT)
In-Reply-To: <222756.1344.1333504831095.JavaMail.geo-discussion-forums@ynne15>
References: <28105680.268.1333471484343.JavaMail.geo-discussion-forums@ynko12>
<CACnq-u+-Z=yf28RFPky9BB-WZ4d+5Ms_yNFV9sxmoroeuQm...@mail.gmail.com> <222756.1344.1333504831095.JavaMail.geo-discussion-forums@ynne15>
From: John Resig <jere...@gmail.com>
Date: Tue, 3 Apr 2012 22:22:42 -0400
Message-ID: <CAJXLSTCjVp8thRJY0LrA-TDNUtuGvsyjiTOmxd+rrJyXu74...@mail.gmail.com>
Subject: Re: [jquery-bugs-team] Closure-compiler Build Passes All Unit Tests
To: jquery-bugs-team@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1
This is awesome work, Chad. Thank you so much for tackling this!
--John
On Tue, Apr 3, 2012 at 10:00 PM, Chad Killingsworth
<chadkillingswo...@missouristate.edu> wrote:
> Changes have been pushed and are available for review. There are plenty of
> opportunities to improve/optimize what's there - I was going for functional
> on the first go round.
>
> I've tried to pay attention to the jQuery coding style, but I'm inevitably
> going to have missed something.
>
> Also, the Makefile will need updated to properly build the compiled version
> of the tests. I'll need some guidance there as I'm not a regular user of
> make.
>
> Github links:
>
> https://github.com/ChadKillingsworth/jquery/tree/closure-compiler
> https://github.com/ChadKillingsworth/sizzle/tree/closure-compiler
>
> Chad Killingsworth