Closure-compiler Build Passes All Unit Tests - jQuery Bugs Team

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Closure-compiler Build Passes All Unit Tests
Received-SPF: pass (google.com: domain of addyosm...@gmail.com designates 209.85.214.177 as permitted sender) client-ip=209.85.214.177;
MIME-Version: 1.0
In-Reply-To: <CAHfnhfrSNtP5jHHsapRRbZYoUjJZKdAN0C_Ous7P7TYDZZ4...@mail.gmail.com>
References: <28105680.268.1333471484343.JavaMail.geo-discussion-forums@ynko12>
 <CACnq-u+-Z=yf28RFPky9BB-WZ4d+5Ms_yNFV9sxmoroeuQm...@mail.gmail.com>
 <222756.1344.1333504831095.JavaMail.geo-discussion-forums@ynne15>
 <CAJXLSTCjVp8thRJY0LrA-TDNUtuGvsyjiTOmxd+rrJyXu74...@mail.gmail.com>
 <CAGgai8Gw_+5zeOO=G0GzxKBPDv=fWu_-4xMEXNCcpKrYR4M...@mail.gmail.com>
 <21737051.467.1333546946463.JavaMail.geo-discussion-forums@ynhs12>
 <6598585.476.1333593899401.JavaMail.geo-discussion-forums@vbbdy9>
 <-1305059656394535102@unknownmsgid> <CAHfnhfrSNtP5jHHsapRRbZYoUjJZKdAN0C_Ous7P7TYDZZ4...@mail.gmail.com>
From: Addy Osmani <addyosm...@gmail.com>
Date: Thu, 5 Apr 2012 10:16:02 +0100
Message-ID: <CAC9JBOUALcC8v0j=s2A-D0ZoXg0YOwWoNU9AWkPey+m0AHJ...@mail.gmail.com>
Subject: Re: [jquery-bugs-team] Closure-compiler Build Passes All Unit Tests
To: jquery-bugs-team@googlegroups.com
Content-Type: multipart/alternative; boundary=e89a8ff1c77255643204bceafecd

--e89a8ff1c77255643204bceafecd
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

> Both source and unit tests now compile without warnings!

Excellent work, Chad! As Mike said this is absolutely epic.

On Thu, Apr 5, 2012 at 5:09 AM, Rick Waldron <waldron.r...@gmail.com> wrote=
:

> I'm going to try and tackle integrating this into the new grunt build
> system, next week at dev days
>
>
> Rick
>
>
> On Wed, Apr 4, 2012 at 8:06 PM, Mike Sherov <mike.she...@gmail.com> wrote=
:
>
>> It's been said several times in this thread, but this is freaking epic.
>> EPIC.
>>
>> Mike Sherov
>> Lead Programmer
>> SNAP Interactive, Inc.
>> Ticker: STVI.OB
>>
>> Sent Via Mobile: Please excuse my grammar, tone, and punctuation. My
>> thumbs can't create flowery prose.
>>
>> On Apr 4, 2012, at 10:45 PM, Chad Killingsworth <
>> chadkillingswo...@missouristate.edu> wrote:
>>
>> Both source and unit tests now compile without warnings! I've also
>> addressed jshint issues (although I had to add the "sub: true" option to
>> jshint).
>>
>> I've started adding type annotations to the publicly documented methods.
>>
>> Also note, I renamed the test/closure-compiler/comp directory to be
>> test/closure-compiler/build so you'll need to adjust the previous
>> instructions slightly.
>>
>> Chad
>>
>> On Wednesday, April 4, 2012 8:42:26 AM UTC-5, Chad Killingsworth wrote:
>>>
>>> To compile the tests:
>>>
>>>    1. Download
>>>    http://people.missouristate.edu/chadkillingsworth/jquery/compiler.zi=
p and
>>>    place it in the jQuery build folder.
>>>    2. make jquery-cc
>>>    3. md tests/closure-compiler/comp
>>>    4. java -jar build/compiler.jar --flagfile
>>>    test/closure-compiler/compile_tests.flags
>>>
>>> I've now run the unit tests on FireFox 11, IE 9, IE9 set as IE8 and all
>>> of them pass. I've also run the tests on the Chrome Dev Channel (versio=
n
>>> 19), however not all of the tests on the 1.8 branch succeeded before I =
made
>>> my changes - but my changes at least fail in the same way.
>>>
>>> I'm currently working on changes to silence/fix compiler warnings in th=
e
>>> src. I'd also like to add full type annotations for the publicly docume=
nted
>>> functions. I'm not too worried about compiler warnings in the unit test=
s -
>>> although I'll fix the easy ones.
>>>
>>> On Wednesday, April 4, 2012 3:26:04 AM UTC-5, J=F6rn Zaefferer wrote:
>>>>
>>>> For comparing:
>>>>
>>>>
>>>> https://github.com/ChadKillingsworth/jquery/compare/jquery:1.8pre...Ch=
adKillingsworth:closure-compiler
>>>> https://github.com/ChadKillingsworth/sizzle/compare/closure-compiler
>>>>
>>>>
>>>> On Wed, Apr 4, 2012 at 04:22, John Resig <jere...@gmail.com> wrote:
>>>>
>>>>> This is awesome work, Chad. Thank you so much for tackling this!
>>>>>
>>>>> --John
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Apr 3, 2012 at 10:00 PM, Chad Killingsworth
>>>>> <chadkillingswo...@missouristate.edu> wrote:
>>>>> > Changes have been pushed and are available for review. There are
>>>>> plenty of
>>>>> > opportunities to improve/optimize what's there - I was going for
>>>>> functional
>>>>> > on the first go round.
>>>>> >
>>>>> > I've tried to pay attention to the jQuery coding style, but I'm
>>>>> inevitably
>>>>> > going to have missed something.
>>>>> >
>>>>> > Also, the Makefile will need updated to properly build the compiled
>>>>> version
>>>>> > of the tests. I'll need some guidance there as I'm not a regular
>>>>> user of
>>>>> > make.
>>>>> >
>>>>> > Github links:
>>>>> >
>>>>> > https://github.com/ChadKillingsworth/jquery/tree/closure-compiler
>>>>> > https://github.com/ChadKillingsworth/sizzle/tree/closure-compiler
>>>>> >
>>>>> > Chad Killingsworth
>>>>>
>>>>
>>>>
>>> On Wednesday, April 4, 2012 3:26:04 AM UTC-5, J=F6rn Zaefferer wrote:
>>>>
>>>> For comparing:
>>>>
>>>>
>>>> https://github.com/ChadKillingsworth/jquery/compare/jquery:1.8pre...Ch=
adKillingsworth:closure-compiler
>>>> https://github.com/ChadKillingsworth/sizzle/compare/closure-compiler
>>>>
>>>>
>>>> On Wed, Apr 4, 2012 at 04:22, John Resig <jere...@gmail.com> wrote:
>>>>
>>>>> This is awesome work, Chad. Thank you so much for tackling this!
>>>>>
>>>>> --John
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Apr 3, 2012 at 10:00 PM, Chad Killingsworth
>>>>> <chadkillingswo...@missouristate.edu> wrote:
>>>>> > Changes have been pushed and are available for review. There are
>>>>> plenty of
>>>>> > opportunities to improve/optimize what's there - I was going for
>>>>> functional
>>>>> > on the first go round.
>>>>> >
>>>>> > I've tried to pay attention to the jQuery coding style, but I'm
>>>>> inevitably
>>>>> > going to have missed something.
>>>>> >
>>>>> > Also, the Makefile will need updated to properly build the compiled
>>>>> version
>>>>> > of the tests. I'll need some guidance there as I'm not a regular
>>>>> user of
>>>>> > make.
>>>>> >
>>>>> > Github links:
>>>>> >
>>>>> > https://github.com/ChadKillingsworth/jquery/tree/closure-compiler
>>>>> > https://github.com/ChadKillingsworth/sizzle/tree/closure-compiler
>>>>> >
>>>>> > Chad Killingsworth
>>>>>
>>>>
>>>>
>


--=20

*Addy Osmani*

Software Engineer at Aol | jQuery Team member
Blogger at: http://addyosmani.com
Phone: +44 7501 594 382

--e89a8ff1c77255643204bceafecd
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

&gt;=A0<span style>Both source and unit tests now compile without warnings!=
=A0</span><div><font color=3D"#222222" face=3D"arial, sans-serif"><br></fon=
t></div><div><font color=3D"#222222" face=3D"arial, sans-serif">Excellent w=
ork, Chad! As Mike said this is absolutely epic.<br>

</font><br><div class=3D"gmail_quote">On Thu, Apr 5, 2012 at 5:09 AM, Rick =
Waldron <span dir=3D"ltr">&lt;<a href=3D"mailto:waldron.r...@gmail.com">wal=
dron.r...@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
>

I&#39;m going to try and tackle integrating this into the new grunt build s=
ystem, next week at dev days<span class=3D"HOEnZb"><font color=3D"#888888">=
<div><br></div><div><br></div></font></span><div><span class=3D"HOEnZb"><fo=
nt color=3D"#888888">Rick</font></span><div>

<div class=3D"h5"><br><br><div class=3D"gmail_quote">On Wed, Apr 4, 2012 at=
 8:06 PM, Mike Sherov <span dir=3D"ltr">&lt;<a href=3D"mailto:mike.sherov@g=
mail.com" target=3D"_blank">mike.she...@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div bgcolor=3D"#FFFFFF"><div>It&#39;s been =
said several times in this thread, but this is freaking epic. EPIC.<br><br>=
Mike Sherov<div>



Lead Programmer</div><div>SNAP Interactive, Inc.</div><div>Ticker: STVI.OB<=
/div>
<div><br></div><div>Sent Via Mobile: Please excuse my grammar, tone, and pu=
nctuation. My thumbs can&#39;t create flowery prose.</div></div><div><div><=
div><br>On Apr 4, 2012, at 10:45 PM, Chad Killingsworth &lt;<a href=3D"mail=
to:chadkillingswo...@missouristate.edu" target=3D"_blank">chadkillingsworth=
@missouristate.edu</a>&gt; wrote:<br>




<br></div><div></div><blockquote type=3D"cite"><div>Both source and unit te=
sts now compile without warnings! I&#39;ve also addressed jshint issues (al=
though I had to add the &quot;sub: true&quot; option to jshint).<div><br>




</div><div>I&#39;ve started adding type annotations to the publicly documen=
ted methods.</div><div><br></div><div>Also note, I renamed the test/closure=
-compiler/comp directory to be test/closure-compiler/build so you&#39;ll ne=
ed to adjust the previous instructions slightly.</div>




<div><br></div><div>Chad<br><br>On Wednesday, April 4, 2012 8:42:26 AM UTC-=
5, Chad Killingsworth wrote:<blockquote class=3D"gmail_quote" style=3D"marg=
in:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex">To comp=
ile the tests:<div>




<ol><li><span style=3D"line-height:normal">Download=A0<a href=3D"http://peo=
ple.missouristate.edu/chadkillingsworth/jquery/compiler.zip" target=3D"_bla=
nk">http://people.missouristate.edu/chadkillingsworth/jquery/compiler.zip</=
a>=A0and place it in the jQuery build folder.</span></li>




<li><span style=3D"line-height:normal">make jquery-cc</span></li><li><span =
style=3D"line-height:normal">md tests/closure-compiler/comp</span></li><li>=
<span style=3D"line-height:normal">java -jar build/compiler.jar --flagfile =
test/closure-compiler/compile_tests.flags</span></li>




</ol><div>I&#39;ve now run the unit tests on FireFox 11, IE 9, IE9 set as I=
E8 and all of them pass. I&#39;ve also run the tests on the Chrome Dev Chan=
nel (version 19), however not all of the tests on the 1.8 branch succeeded =
before I made my changes - but my changes at least fail in the same way.</d=
iv>




<div><br></div><div>I&#39;m currently working on changes to silence/fix com=
piler warnings in the src. I&#39;d also like to add full type annotations f=
or the publicly documented functions. I&#39;m not too worried about compile=
r warnings in the unit tests - although I&#39;ll fix the easy ones.</div>




<br>On Wednesday, April 4, 2012 3:26:04 AM UTC-5, J=F6rn Zaefferer wrote:<b=
lockquote class=3D"gmail_quote" style=3D"margin:0;margin-left:0.8ex;border-=
left:1px #ccc solid;padding-left:1ex">For comparing:<div><br></div><div><a =
href=3D"https://github.com/ChadKillingsworth/jquery/compare/jquery:1.8pre..=
.ChadKillingsworth:closure-compiler" target=3D"_blank">https://github.com/C=
hadKillingsworth/jquery/compare/jquery:1.8pre...ChadKillingsworth:closure-c=
ompiler</a></div>






<div><a href=3D"https://github.com/ChadKillingsworth/sizzle/compare/closure=
-compiler" target=3D"_blank">https://github.com/ChadKillingsworth/sizzle/co=
mpare/closure-compiler</a></div><div><br><br><div class=3D"gmail_quote">On =
Wed, Apr 4, 2012 at 04:22, John Resig <span dir=3D"ltr">&lt;<a href=3D"mail=
to:jere...@gmail.com" target=3D"_blank">jere...@gmail.com</a>&gt;</span> wr=
ote:<br>






<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">This is awesome work, Chad. Thank you so muc=
h for tackling this!<br>
<span><font color=3D"#888888"><br>
--John<br>
</font></span><div><div><br>
<br>
<br>
On Tue, Apr 3, 2012 at 10:00 PM, Chad Killingsworth<br>
&lt;<a href=3D"mailto:chadkillingswo...@missouristate.edu" target=3D"_blank=
">chadkillingswo...@missouristate.edu</a>&gt; wrote:<br>
&gt; Changes have been pushed and are available for review. There are plent=
y of<br>
&gt; opportunities to improve/optimize what&#39;s there - I was going for f=
unctional<br>
&gt; on the first go round.<br>
&gt;<br>
&gt; I&#39;ve tried to pay attention to the jQuery coding style, but I&#39;=
m inevitably<br>
&gt; going to have missed something.<br>
&gt;<br>
&gt; Also, the Makefile will need updated to properly build the compiled ve=
rsion<br>
&gt; of the tests. I&#39;ll need some guidance there as I&#39;m not a regul=
ar user of<br>
&gt; make.<br>
&gt;<br>
&gt; Github links:<br>
&gt;<br>
&gt; <a href=3D"https://github.com/ChadKillingsworth/jquery/tree/closure-co=
mpiler" target=3D"_blank">https://github.com/ChadKillingsworth/jquery/tree/=
closure-compiler</a><br>
&gt; <a href=3D"https://github.com/ChadKillingsworth/sizzle/tree/closure-co=
mpiler" target=3D"_blank">https://github.com/ChadKillingsworth/sizzle/tree/=
closure-compiler</a><br>
&gt;<br>
&gt; Chad Killingsworth<br>
</div></div></blockquote></div><br></div>
</blockquote><br>On Wednesday, April 4, 2012 3:26:04 AM UTC-5, J=F6rn Zaeff=
erer wrote:<blockquote class=3D"gmail_quote" style=3D"margin:0;margin-left:=
0.8ex;border-left:1px #ccc solid;padding-left:1ex">For comparing:<div><br><=
/div>




<div><a href=3D"https://github.com/ChadKillingsworth/jquery/compare/jquery:=
1.8pre...ChadKillingsworth:closure-compiler" target=3D"_blank">https://gith=
ub.com/ChadKillingsworth/jquery/compare/jquery:1.8pre...ChadKillingsworth:c=
losure-compiler</a></div>






<div><a href=3D"https://github.com/ChadKillingsworth/sizzle/compare/closure=
-compiler" target=3D"_blank">https://github.com/ChadKillingsworth/sizzle/co=
mpare/closure-compiler</a></div><div><br><br><div class=3D"gmail_quote">On =
Wed, Apr 4, 2012 at 04:22, John Resig <span dir=3D"ltr">&lt;<a href=3D"mail=
to:jere...@gmail.com" target=3D"_blank">jere...@gmail.com</a>&gt;</span> wr=
ote:<br>






<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">This is awesome work, Chad. Thank you so muc=
h for tackling this!<br>
<span><font color=3D"#888888"><br>
--John<br>
</font></span><div><div><br>
<br>
<br>
On Tue, Apr 3, 2012 at 10:00 PM, Chad Killingsworth<br>
&lt;<a href=3D"mailto:chadkillingswo...@missouristate.edu" target=3D"_blank=
">chadkillingswo...@missouristate.edu</a>&gt; wrote:<br>
&gt; Changes have been pushed and are available for review. There are plent=
y of<br>
&gt; opportunities to improve/optimize what&#39;s there - I was going for f=
unctional<br>
&gt; on the first go round.<br>
&gt;<br>
&gt; I&#39;ve tried to pay attention to the jQuery coding style, but I&#39;=
m inevitably<br>
&gt; going to have missed something.<br>
&gt;<br>
&gt; Also, the Makefile will need updated to properly build the compiled ve=
rsion<br>
&gt; of the tests. I&#39;ll need some guidance there as I&#39;m not a regul=
ar user of<br>
&gt; make.<br>
&gt;<br>
&gt; Github links:<br>
&gt;<br>
&gt; <a href=3D"https://github.com/ChadKillingsworth/jquery/tree/closure-co=
mpiler" target=3D"_blank">https://github.com/ChadKillingsworth/jquery/tree/=
closure-compiler</a><br>
&gt; <a href=3D"https://github.com/ChadKillingsworth/sizzle/tree/closure-co=
mpiler" target=3D"_blank">https://github.com/ChadKillingsworth/sizzle/tree/=
closure-compiler</a><br>
&gt;<br>
&gt; Chad Killingsworth<br>
</div></div></blockquote></div><br></div>
</blockquote></div></blockquote></div></div></blockquote></div></div></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><br><b>Addy =
Osmani</b><br><br>Software Engineer at Aol <span style=3D"color:rgb(204,204=
,204)">|</span> <span style=3D"color:rgb(192,192,192)"></span>jQuery Team m=
ember<br>

Blogger at: <a href=3D"http://addyosmani.com" target=3D"_blank">http://addy=
osmani.com</a> <br><div>Phone: +44 7501 594 382</div><br>
</div>

--e89a8ff1c77255643204bceafecd--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
