either a bug or semantics with noFullScreen, noVolume

73 views
Skip to first unread message

Greg

unread,
Dec 10, 2012, 4:38:37 PM12/10/12
to jpl...@googlegroups.com
I wanted to add the fullscreen button to iPad and Android Devices since I have written a fullscreen function.  However, if I enter noFullScreen in my options as:

noFullScreen: {
                    msie: /msie [0-6]/,
                    iphone: /iphone/,
                    ipod: /ipod/,
                    blackberry: /blackberry/,
                    windows_ce: /windows ce/,
                    webos: /webos/
                }

the fullscreen buttons are still missing on iPad and Android.  This is because when you use

 $.extend(true,{},this.options,options)

the code leaves in the options that are not supplied.  I can get by with:

noFullScreen: {
                    msie: /msie [0-6]/,
                    ipad: null,
                    iphone: /iphone/,
                    ipod: /ipod/,
                    android_pad: null,
                    android_phone: null,
                    blackberry: /blackberry/,
                    windows_ce: /windows ce/,
                    webos: /webos/
                },

but I feel it would be better code function to specifically overwrite the values of noFullScreen and noVolume instead of just extending them.

Reply all
Reply to author
Forward
0 new messages