Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Joomla! bug Squad
Home
+ new post
About this group
Join this group
Definite guide for patch and pull requesting for J25 tracker
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   11 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
nant  
View profile  
 More options Nov 10 2012, 2:49 am
From: nant <nanti...@gmail.com>
Date: Fri, 9 Nov 2012 23:49:44 -0800 (PST)
Local: Sat, Nov 10 2012 2:49 am
Subject: Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author

Sorry to post this - I did do some googling but found various resources and
want to pinpoint the most prominent one in order to invest time and fix an
issue I have already identified on the tracker.

Can someone please post a link of resources I can study to learn:

1. How to create a patch
2. How to propose a pull request

Thanks guys and gals!
Nick


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ole Ottosen (ot2sen)  
View profile  
 More options Nov 10 2012, 3:11 am
From: "Ole Ottosen (ot2sen)" <ot2...@gmail.com>
Date: Sat, 10 Nov 2012 09:11:16 +0100
Local: Sat, Nov 10 2012 3:11 am
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author

Hi Nick,

Try have a look at these:
http://docs.joomla.org/Git_for_Coders
http://docs.joomla.org/Git_for_Testers_and_Trackers
http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

Cheers,
Ole


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
nant  
View profile  
 More options Nov 10 2012, 9:17 am
From: nant <nanti...@gmail.com>
Date: Sat, 10 Nov 2012 06:17:34 -0800 (PST)
Local: Sat, Nov 10 2012 9:17 am
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author

thanks for links!

question: from github ui can i edit multiple files as part of same pull request?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Savov  
View profile  
 More options Nov 10 2012, 11:34 am
From: "Nick Savov" <n...@iowawebcompany.com>
Date: Sat, 10 Nov 2012 10:34:09 -0600
Local: Sat, Nov 10 2012 11:34 am
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author
Hi Nick,

Also, check out the following page for the process:
http://docs.joomla.org/Filing_bugs_and_issues

If it's a bug that only appears in 2.5, then you can put it in the 2.5 bug
tracker.  But if it appears for both 2.5 and 3.0, then it goes in the CMS
tracker.

Kind regards,
Nick S.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Savov  
View profile  
 More options Nov 10 2012, 11:56 am
From: "Nick Savov" <n...@iowawebcompany.com>
Date: Sat, 10 Nov 2012 10:56:37 -0600
Local: Sat, Nov 10 2012 11:56 am
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author
If you're using the this method:
http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

I think you can only edit one file.

For multiple files, just using the Fork button, edit your files, then send
the pull request.

Kind regards,
Nick


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Elin  
View profile  
 More options Nov 10 2012, 5:08 pm
From: Elin <elin.war...@gmail.com>
Date: Sat, 10 Nov 2012 14:08:47 -0800 (PST)
Local: Sat, Nov 10 2012 5:08 pm
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author

Actually .. not true.

After you change the first file you will have a branch in your fork called
patch-1 (or some number).
At that point if you are in the patch-1 branch you can also edit any other
files in your own repository and save them.

Then when you are ready do the pull request from the branch to
joomla-cms/master.

All the files you edited will be included in the pull request.

Elin


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Savov  
View profile  
 More options Nov 10 2012, 5:41 pm
From: "Nick Savov" <n...@iowawebcompany.com>
Date: Sat, 10 Nov 2012 16:41:23 -0600
Local: Sat, Nov 10 2012 5:41 pm
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author
Wow, that's really cool!  That really simplifies the process!

So the key is after making an edit and getting redirected to the "New Pull
Request" page (which has no option to continue editing), don't submit the
Pull Request, but rather click on your project and go to that branch.

Thanks Elin!

Kind regards,
Nick


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
nant  
View profile  
 More options Nov 11 2012, 3:22 pm
From: nant <nanti...@gmail.com>
Date: Sun, 11 Nov 2012 12:22:14 -0800 (PST)
Local: Sun, Nov 11 2012 3:22 pm
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author

thanks, pull request done, now what?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Savov  
View profile  
 More options Nov 11 2012, 5:58 pm
From: "Nick Savov" <n...@iowawebcompany.com>
Date: Sun, 11 Nov 2012 16:58:02 -0600
Local: Sun, Nov 11 2012 5:58 pm
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author
Did you follow http://docs.joomla.org/Filing_bugs_and_issues ?

Kind regards,
Nick


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
nant  
View profile  
 More options Nov 12 2012, 12:59 am
From: nant <nanti...@gmail.com>
Date: Sun, 11 Nov 2012 21:58:59 -0800 (PST)
Local: Mon, Nov 12 2012 12:58 am
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author

i think so.
tracker item has been open for a couple of weeks now and issue has been confirmed.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEd...

do you see anything missing from my end?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Savov  
View profile  
 More options Nov 12 2012, 10:15 am
From: "Nick Savov" <n...@iowawebcompany.com>
Date: Mon, 12 Nov 2012 09:15:29 -0600
Local: Mon, Nov 12 2012 10:15 am
Subject: Re: [jbs] Definite guide for patch and pull requesting for J25 tracker
Print | Individual message | Show original | Report this message | Find messages by this author
No, looks good.  Now it just needs two testers to confirm that it's
working, then it can be set to RTC (Ready to Commit)

Kind regards,
Nick S.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google