Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion New way of handling Issues and Pull Requests in GitHub
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Chad Windnagle  
View profile  
 More options Oct 8 2012, 9:48 pm
From: Chad Windnagle <drmmr...@gmail.com>
Date: Mon, 8 Oct 2012 21:48:32 -0400
Local: Mon, Oct 8 2012 9:48 pm
Subject: Re: [jplatform] New way of handling Issues and Pull Requests in GitHub

I for one am very very in favor of this. I think it's an appropriate to use
Github's core features to better help you as maintainers organize and keep
track of things, and it helps set expectation levels for developers
submitting pull requests.

In short, bravo!

I believe the hardest communication problem that you will need to overcome
is the conveying that a closed request isn't a rejected request. It will be
important to state when closing a request that it is acceptable, with the
exception that necessary changes are made.

Thanks for taking a look at this. I appreciate your efforts!

-Chad

Regards,
Chad Windnagle
Fight SOPA <https://www.google.com/landing/takeaction/>

On Mon, Oct 8, 2012 at 9:43 PM, Louis Landry <louislan...@gmail.com> wrote:
> Hi all,

> So I've been brainstorming with Ian and Andrew about how to manage the
> pull request queue and such better.  We are trying to find ways to reduce
> the signal to noise ratio for maintainers, as well as do a better job of
> communication about intent with the pull requests.  Here's what we'd like
> to try:

> *Open/Closed*

> Going forwards we are going to treat open/closed a little differently than
> we do currently.  If a pull request is ready to be reviewed (by maintainers
> and non-maintainers) it will be left open.  If there are changes that need
> to be made, unit tests that need to be fixed, code style issues to be
> cleaned up, missing documentation, etc. then comments will be left and the
> pull request will be closed until the developer has completed the changes.
>  Our expectation is that once the changes have been made developers will
> re-open the pull request for review.

> What this effectively does is ensure that at all times we know what is
> ready to be looked at, and what is still being worked on.  It is important
> to understand that just because we close it doesn't mean that it is
> rejected, but we are simply saying that it needs some work before it can be
> considered for further review.

> *Milestones*
> *
> *
> Because of the change in the way we treat Open/Closed state for pull
> requests (and for housekeeping purposes) we are also going to be utilizing
> the issue tracker milestones feature going forward.  If we assign a
> milestone for a pull request you can consider the pull request accepted for
> the given release (milestone) assuming that we work out all the kinks.  If
> there are changes we'd like made, or test/style fixes than we will assign a
> milestone and close the issue.  Hopefully this will help us track what is
> being worked on in a given release, what was done in given releases, and
> communicate better with all of you about if and when we want to include the
> code you've submitted for review.

> *Browsing Issues*

> Those of you wanting to see what is going on in a given release would be
> better served viewing things through the issue tracker in this way of
> working.  That will give you an ability to look at everything attached to a
> given milestone.  Those of you who want to help us review code (and please
> do) you can trust that everything in the open pull request queue is ready
> for review.  Should make it much easier to find things to look at and
> comment on.

> Nothing is perfect, but our hope is that this will help us manage things a
> bit better and make it easier for all of you to understand what is going on
> and what is being worked on in a given release.  To those of you submitting
> code, hopefully it will be more clear if/when we expect to get your code
> merged into the codebase.

> Thoughts?

> - Louis


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.