JDatabaseExporter Question

151 views
Skip to first unread message

Elin Waring

unread,
Aug 15, 2012, 12:12:13 AM8/15/12
to joomla-de...@googlegroups.com
Hi,

The docblocks for JDatabaseExporter imply that data and/or structure can be exported but for the life of me I'm not finding a way to get data (or not to get structure for that matter--also a bit confusing in the docblocks). Am I missing something or is this something (either code or docblocks) that needs fixing? (I'm figuring out how to do the data alternatively but I could clean up  that code an put it into the exporter perhaps.)

Elin

Nikolai Plath

unread,
Aug 15, 2012, 12:28:14 AM8/15/12
to joomla-de...@googlegroups.com
There was a pull request about the data stuff..
https://github.com/joomla/joomla-platform/pull/707

Elin Waring

unread,
Aug 15, 2012, 4:09:24 AM8/15/12
to joomla-de...@googlegroups.com
Wow there sure was; interesting conversation there. I wonder if rather than addressing some of the larger possibilities mentioned in  the discussion it would be reasonable to just work on getting the data out in some standard format such as the one you proposed. It seems a shame to not solve the basic issues because there are larger and more interesting ones in play.

Do you have thoughts on how withStructure() is suposed to work? While it is certainly true that it will return true or false if set to true or false (which is what the tests  test) it doesn't seem to actually do anything else. It's as though the condition that is supposed to be associated with it is missing.

It seems like the only thing that actually happened in the meantime is that the typeOnly issue was addressed.  Is that right?

Elin

Amy Stephen

unread,
Aug 15, 2012, 3:29:26 PM8/15/12
to joomla-de...@googlegroups.com
Elin - you and your "developers are off working on 'interesting problems' rather than what is needed comments!" Don't sociologists have interesting problems? Goodness, you say that a lot!  ;-)

In all seriousness, though, I don't see that in this issue, or most of the time you suggest it. What I saw was some good collaboration but the patch sat three months and no longer merged. That was noted three months ago and the closed.

If someone has interest, fixing those merge issues will get it back on track. Hopefully, it won't sit three months, again, and can go in.

Nikolai - seems like you submit a number of good patches that sit a long time. Might be good to touch base with the committers and see what's going on. It really can be discouraging to do all that work and have it wasted. Since I am certain that's not the goal and since you so obviously want to contribute and have the coding chops to do so, a discussion on how to smooth things out might be helpful.


Elin Waring

unread,
Aug 15, 2012, 5:24:03 PM8/15/12
to joomla-de...@googlegroups.com


@Nikolai, @Andrew do you want me to try to update the pull request? Or do we think it's not likely to ever be merged? I'd sure like to be able to export data and was very happy to see Nikolai's code for doing so which seems to work great but I can always just borrow it for my application.  However if it's not going to be fixed let's go ahead and update the doc blocks to take out the references to exporting date.

@ Amy, Please consider not hijacking threads or making personal comments.


Elin

Amy Stephen

unread,
Aug 15, 2012, 7:49:34 PM8/15/12
to joomla-de...@googlegroups.com
On Wed, Aug 15, 2012 at 4:24 PM, Elin Waring <elin....@gmail.com> wrote:


@ Amy, Please consider not hijacking threads or making personal comments.


Stay on topic, Elin, and stop insulting contributors.

Nikolai Plath

unread,
Aug 15, 2012, 11:33:07 PM8/15/12
to joomla-de...@googlegroups.com
Hello ladies,
first of all it takes a lot more to stop me from contributing to the Joomla! project.

In the dark ages - before GitHub - it was a lot more complicated to even offer a contribution. I fell very comfort now with the possibilities that git and GitHub pull requests offer and if a pull request (ore more) are not accepted - that's fine with me if there is at least some response.

But yes, there is still some room for improvement in the communication between the contributors and the committers.

As for the XML exporters..
I wrote that part for a project and thought that it could be useful for the "rest of the world" - if it is not the case, just let it go.

If somebody wants to update and resubmit the pull request - excellent :)

Please stay calm - the Joomla! community needs both of you ;)
Nikolai

brian teeman

unread,
Aug 16, 2012, 10:00:58 AM8/16/12
to joomla-de...@googlegroups.com
@amy @elin please get a room

Amy Stephen

unread,
Aug 16, 2012, 10:48:02 AM8/16/12
to joomla-de...@googlegroups.com
Thanks for your gracious kindness, Nikolai, it makes a positive difference and is appreciated.

Elin - my apologies for my rude response. I know what it's like to use the platform, run into a problem, find a patch that could have solved the problem only to learn that it wasn't applied. In this case, it does appear that a question was asked about how to solve a problem and someone responded with help. Not sure why it sat so long, but I don't think it was due to a lack of interest or more interesting issues to work on, just life. Something we could both enjoy more of and less of this sometimes. ;-)

Cheers!
Reply all
Reply to author
Forward
0 new messages