Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Joomla! Platform Development
Home
About this group
Contact owner to join
Message from discussion New way of handling Issues and Pull Requests in GitHub
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
piotr_cz  
View profile  
 More options Oct 18 2012, 6:21 pm
From: piotr_cz <pkoniec...@hotmail.com>
Date: Thu, 18 Oct 2012 15:21:24 -0700 (PDT)
Local: Thurs, Oct 18 2012 6:21 pm
Subject: Re: New way of handling Issues and Pull Requests in GitHub
Print | View thread | Show original | Report this message | Find messages by this author
What I meant is to avoid situations like one that happened to Don. He
closed the PR and unintentionally left a comment 'open' or 'reopen'.
This might be quite a common word in packages so escaping natural
language word could be helpful.

I kinda feel like trying to be too smart :)

On Oct 18, 6:21 pm, Louis Landry <louislan...@gmail.com> wrote:

> From my previous email:

> It will look to see if the author of a pull request leaves a comment

> > containing the word `reopen` or `re-open` on a pull request that has been
> > closed but not merged.  If it detects that event it will automatically
> > reopen the pull request, thus putting it back in the queue for review.

> That is exactly the behavior that has been built.  If the author of a pull
> request comments with "don't reopen this request" and it is opened, then
> the author has the ability to close it right there.  I appreciate the
> enthusiasm guys, but the point isn't to do natural language processing or
> make it perfect.  The point was to make it usable and simple.

> Cheers.

> - Louis

> On Thu, Oct 18, 2012 at 6:56 AM, Donald Gilbert <dilbert4l...@gmail.com>wrote:

> > That's a good idea piotr.

> > Also, what happens if one of my PR's is closed, and someone else goes in
> > and leaves a comment with "reopen" in it? Does the jenkins bot have
> > filtering in place to only reopen if it's requested by the submitter?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google