Received: by 10.66.80.4 with SMTP id n4mr2419875pax.7.1351534360714;
        Mon, 29 Oct 2012 11:12:40 -0700 (PDT)
X-BeenThere: joomla-dev-platform@googlegroups.com
Received: by 10.68.223.67 with SMTP id qs3ls25494514pbc.8.gmail; Mon, 29 Oct
 2012 11:12:39 -0700 (PDT)
Received: by 10.68.243.137 with SMTP id wy9mr483949pbc.0.1351534359812;
        Mon, 29 Oct 2012 11:12:39 -0700 (PDT)
Date: Mon, 29 Oct 2012 11:12:39 -0700 (PDT)
From: Ian <ianlen...@gmail.com>
To: joomla-dev-platform@googlegroups.com
Message-Id: <8ab4d3e7-f553-4965-baf8-7e8f4a28d901@googlegroups.com>
In-Reply-To: <ef23ee0a-cac5-4412-8950-42da36503a59@googlegroups.com>
References: <CAOwECdKN20jxsJe9rjpVp76=3FpzMkjdTEfSuCW3VxQV4m1cYw@mail.gmail.com>
 <CAAuivsjTWUoVE1dpfHgOKz5VSQZfu+raPAUGs84-Vq7p4chVZQ@mail.gmail.com>
 <CAA=5Qbcn3OHkM3-C+DfW-foAk0bDdq8mjtp+WaO3hM7j234Ohg@mail.gmail.com>
 <9a59f649-fc93-4436-a4a6-8a1defd16edf@googlegroups.com> <f756f46e-2506-4f29-9260-010e6e1ef394@googlegroups.com>
 <360a927c-9a28-4f7d-8d6b-4cb993c28666@googlegroups.com> <8c3ccee2-d0a5-410e-a0f9-7a706e7c0146@googlegroups.com>
 <CAOwECdJ9JAQ53yz_jUDn1ZhaK5TSKtnjDYE-zeHo_-qJokTWQg@mail.gmail.com>
 <22351355-6153-4834-9945-9c87a92decd2@googlegroups.com> <CAAuivsjJbGCfvvTJ6-FtERBwsrEzCWprVZ76JMBBuGFELwRKFw@mail.gmail.com>
 <63860c9f-336d-4ada-858a-0a47193b195e@googlegroups.com> <53eb48b6-c11f-4672-aa7c-72d722991313@googlegroups.com>
 <CAAuivsiAsYiWWp8ixWHFoSvP=EB7Un7Hu1UqY65sebobAFOxGA@mail.gmail.com>
 <ef23ee0a-cac5-4412-8950-42da36503a59@googlegroups.com>
Subject: Re: [jplatform] Call to action: Clean up unit test tree.
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_242_12879948.1351534359315"

------=_Part_242_12879948.1351534359315
Content-Type: multipart/alternative; 
	boundary="----=_Part_243_13652657.1351534359315"

------=_Part_243_13652657.1351534359315
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit



On Saturday, 27 October 2012 05:48:13 UTC-4, Elin Waring wrote:
>
> In terms of cleaning up the tree .. we really need some sniffs 
> specifically for that tree if it is going to work. For example, the biggest 
> issue I see is line length. Tests have a lot of issues with line length 
> because the expects can't include  line endings unless the actual result 
> includes line endings.  Really, I would like to just turn off line length 
> testing in anything in he testing tree. Also there should be a decision 
> about whether @covers is required. It's not present in the majority of 
> tests and it would need a special sniff to only apply to tests.
>
> Covers should not be required.
 

> Also (related to the other thread) we need to decide
>
> protected function setUp ()
> {
> }
>
> or 
>
> protected function setUp ()
> {
>
> }
> Since it is inconsistent.
>
> Empty setUp and tearDown methods should in general be removed.  Non empty 
setUp and tearDown methods should be sure to call parent in case we want to 
add pre and post processing stuff in the future.

Ian

------=_Part_243_13652657.1351534359315
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<br><br>On Saturday, 27 October 2012 05:48:13 UTC-4, Elin Waring  wrote:<bl=
ockquote class=3D"gmail_quote" style=3D"margin: 0;margin-left: 0.8ex;border=
-left: 1px #ccc solid;padding-left: 1ex;">In terms of cleaning up the tree =
.. we really need some sniffs specifically for that tree if it is going to =
work. For example, the biggest issue I see is line length. Tests have a lot=
 of issues with line length because the expects can't include &nbsp;line en=
dings unless the actual result includes line endings. &nbsp;Really, I would=
 like to just turn off line length testing in anything in he testing tree. =
Also there should be a decision about whether @covers is required. It's not=
 present in the majority of tests and it would need a special sniff to only=
 apply to tests.<div><br></div></blockquote><div>Covers should not be requi=
red.</div><div>&nbsp;</div><blockquote class=3D"gmail_quote" style=3D"margi=
n: 0;margin-left: 0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;"><di=
v></div><div>Also (related to the other thread) we need to decide</div><div=
><br></div><div>protected function setUp ()</div><div>{</div><div>}</div><d=
iv><br></div><div>or&nbsp;</div><div><br></div><div><div>protected function=
 setUp ()</div><div>{</div><div><br></div><div>}</div></div><div>Since it i=
s inconsistent.</div><div><br></div></blockquote><div>Empty setUp and tearD=
own methods should in general be removed. &nbsp;Non empty setUp and tearDow=
n methods should be sure to call parent in case we want to add pre and post=
 processing stuff in the future.</div><div><br></div><div>Ian</div>
------=_Part_243_13652657.1351534359315--

------=_Part_242_12879948.1351534359315--