Date: Thu, 18 Oct 2012 20:13:58 -0700 (PDT)
From: Ian <ianlen...@gmail.com>
To: joomla-dev-platform@googlegroups.com
Message-Id: <f394fea7-ccb9-4073-9e5c-25de3ead1b59@googlegroups.com>
In-Reply-To: <c5dfe045-174e-4a15-a66b-cb136a4603d8@o5g2000vbr.googlegroups.com>
References: <48ad5c80-c848-4834-8733-dac4ed5690de@googlegroups.com>
 <CCA49C32.124D4%michael.babker@gmail.com> <CAA=5Qbfnu6Y9Dyh6up5CRL1PTXGZuwdfxwVmq8TqRGkR=7r_AQ@mail.gmail.com>
 <CAOwECdLmPzizA_P1L72jnzZt2yByctHHmMCkUyWJOgGGetC7zQ@mail.gmail.com>
 <2744c65d-5879-4894-beb4-f213efedfdc8@u9g2000vbm.googlegroups.com>
 <78cfbfec-286a-4745-acbf-e116a6e2f981@googlegroups.com> <CAOwECdJHMm5CVjjnpCS1OU-pq_JeWuwTC1necgE4NQymPVxB2w@mail.gmail.com>
 <c5dfe045-174e-4a15-a66b-cb136a4603d8@o5g2000vbr.googlegroups.com>
Subject: Re: New way of handling Issues and Pull Requests in GitHub
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_417_7892058.1350616438652"

------=_Part_417_7892058.1350616438652
Content-Type: multipart/alternative; 
	boundary="----=_Part_418_21182720.1350616438656"

------=_Part_418_21182720.1350616438656
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

If it ends up being an issue we can deal with it then.

Ian

On Thursday, 18 October 2012 18:21:25 UTC-4, piotr_cz wrote:
>
> What I meant is to avoid situations like one that happened to Don. He 
> closed the PR and unintentionally left a comment 'open' or 'reopen'. 
> This might be quite a common word in packages so escaping natural 
> language word could be helpful. 
>
> I kinda feel like trying to be too smart :) 
>
>
> On Oct 18, 6:21 pm, Louis Landry <louislan...@gmail.com> wrote: 
> > From my previous email: 
> > 
> > It will look to see if the author of a pull request leaves a comment 
> > 
> > > containing the word `reopen` or `re-open` on a pull request that has 
> been 
> > > closed but not merged.  If it detects that event it will automatically 
> > > reopen the pull request, thus putting it back in the queue for review. 
> > 
> > That is exactly the behavior that has been built.  If the author of a 
> pull 
> > request comments with "don't reopen this request" and it is opened, then 
> > the author has the ability to close it right there.  I appreciate the 
> > enthusiasm guys, but the point isn't to do natural language processing 
> or 
> > make it perfect.  The point was to make it usable and simple. 
> > 
> > Cheers. 
> > 
> > - Louis 
> > 
> > On Thu, Oct 18, 2012 at 6:56 AM, Donald Gilbert <dilbert4l...@gmail.com>wrote: 
>
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > > That's a good idea piotr. 
> > 
> > > Also, what happens if one of my PR's is closed, and someone else goes 
> in 
> > > and leaves a comment with "reopen" in it? Does the jenkins bot have 
> > > filtering in place to only reopen if it's requested by the submitter? 
>

------=_Part_418_21182720.1350616438656
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

If it ends up being an issue we can deal with it then.<div><br></div><div>Ian<br><br>On Thursday, 18 October 2012 18:21:25 UTC-4, piotr_cz  wrote:<blockquote class="gmail_quote" style="margin: 0;margin-left: 0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;">What I meant is to avoid situations like one that happened to Don. He
<br>closed the PR and unintentionally left a comment 'open' or 'reopen'.
<br>This might be quite a common word in packages so escaping natural
<br>language word could be helpful.
<br>
<br>I kinda feel like trying to be too smart :)
<br>
<br>
<br>On Oct 18, 6:21&nbsp;pm, Louis Landry &lt;<a>louislan...@gmail.com</a>&gt; wrote:
<br>&gt; From my previous email:
<br>&gt;
<br>&gt; It will look to see if the author of a pull request leaves a comment
<br>&gt;
<br>&gt; &gt; containing the word `reopen` or `re-open` on a pull request that has been
<br>&gt; &gt; closed but not merged. &nbsp;If it detects that event it will automatically
<br>&gt; &gt; reopen the pull request, thus putting it back in the queue for review.
<br>&gt;
<br>&gt; That is exactly the behavior that has been built. &nbsp;If the author of a pull
<br>&gt; request comments with "don't reopen this request" and it is opened, then
<br>&gt; the author has the ability to close it right there. &nbsp;I appreciate the
<br>&gt; enthusiasm guys, but the point isn't to do natural language processing or
<br>&gt; make it perfect. &nbsp;The point was to make it usable and simple.
<br>&gt;
<br>&gt; Cheers.
<br>&gt;
<br>&gt; - Louis
<br>&gt;
<br>&gt; On Thu, Oct 18, 2012 at 6:56 AM, Donald Gilbert &lt;<a>dilbert4l...@gmail.com</a>&gt;wrote:
<br>&gt;
<br>&gt;
<br>&gt;
<br>&gt;
<br>&gt;
<br>&gt;
<br>&gt;
<br>&gt; &gt; That's a good idea piotr.
<br>&gt;
<br>&gt; &gt; Also, what happens if one of my PR's is closed, and someone else goes in
<br>&gt; &gt; and leaves a comment with "reopen" in it? Does the jenkins bot have
<br>&gt; &gt; filtering in place to only reopen if it's requested by the submitter?
<br></blockquote></div>
------=_Part_418_21182720.1350616438656--

------=_Part_417_7892058.1350616438652--