JString::parse_url

37 views
Skip to first unread message

Stefan Neculai

unread,
Mar 25, 2012, 8:36:40 PM3/25/12
to joomla-de...@googlegroups.com
Hey,

Trying to fix one bug for JString::parse_url [1] , I have found two ways to do it. One would be with Regex and the other one would be by adding a small tweak to the existing code. I think the second one would be better but I would be glad to hear your thoughts too.

Moreover, I have added in some unit tests for that method. I was hoping that maybe you can take a look over them too.

[1] - https://github.com/joomla/joomla-platform/pull/1006

--
Thanks,
Stefan Neculai

Stefan Neculai

unread,
Apr 1, 2012, 12:19:47 PM4/1/12
to joomla-de...@googlegroups.com
Hey,

Can someone, please, take a look over [1]? I think that the parse_url function from JString is deprecated, because all test pass with the usual parse_url function from PHP.

Stefan
Reply all
Reply to author
Forward
0 new messages