JNode and JTree

[Hannes Papenberg]

Hi folks,
these pull requests are open for a really long time now and I'd like to
ask the team to process them.

https://github.com/joomla/joomla-platform/pull/677
https://github.com/joomla/joomla-cms/pull/144

There are two possibilities with these two classes:

1. We simply accept these pull requests and deprecate those two classes,
removing the last references from the CMS.

2. You decide that we need a node class and close these two requests and
I rewrite those two classes to be actually working. As a foundation for
that, I would use JCategories and JCategoryNode among others.

The first proposal would mean the greater backwards compatibility by
removing the class entirely first and then replacing it with a new one.
On the other hand, those two classes are so much broken that the only
way you can use them is by overriding all methods. The second proposal
would mean a "break" in backwards compatibility, but we would have a
working node class, which we could base JCategories and maybe even JMenu
on. (I think it would be a BIG benefit to have JMenu use a real node class)

Please decide this. Thank you.

Hannes

[Amy Stephen]

Confused, Hannes -- didn't Andrew decide and respond to you 11 days ago?

https://github.com/joomla/joomla-platform/pull/677#issuecomment-4443100

[Andrew Eddie]

On 23 March 2012 00:12, Amy Stephen <amyst...@gmail.com> wrote:
> Confused, Hannes -- didn't Andrew decide and respond to you 11 days ago?
>
> https://github.com/joomla/joomla-platform/pull/677#issuecomment-4443100

Yep.

On 22 March 2012 20:38, Hannes Papenberg <hack...@googlemail.com> wrote:
> these pull requests are open for a really long time now and I'd like to
> ask the team to process them.
>
> https://github.com/joomla/joomla-platform/pull/677
> https://github.com/joomla/joomla-cms/pull/144

We don't have any control over the CMS pulls.

Regards,
Andrew Eddie
http://learn.theartofjoomla.com - training videos for Joomla developers

[Hannes Papenberg]

Ok, I really don't know what TortoiseGit is doing with my repositories,
but it f**ked up about 10 merges so far, breaking the respective pull
requests in the process. I got this one broken, too, so I recreated it
and you can find the new request, prepared like it was discussed, here:
https://github.com/joomla/joomla-platform/pull/1030

Hannes