Pull request #917 test log

[84.le0n]

Hi all,
I've refactored my PostgreSQL database driver, updating it to last
database folder changes, and I've sent pull request #917 [1] .
Automatic test joomla-jenkin reply with this message
"Test log missing. Tests failed to execute.
Checkstyle analysis reported 164 warnings and 0 errors."

What does it mean?
Which are missing files?

Doing tests on my machine I don't receive errors about all
Postgresql's classes, so where is the problem?
Can someone tell me more information about this error ?

[1] https://github.com/joomla/joomla-platform/pull/917

Thank you,
Eng. Gabriele Pongelli.

[Michael Babker]

In the JDatabasePostgresqlTest::setUp method, modify the initial few lines
so that it is only checking for the JPostgresqlTestConfig class and add
the @include_once statement. Use the setUp method in the MySQL and sqlsrv
test classes as an example.

Push those changes and I'll run the unit tests locally (I might need to
update my PG instance first).

[Michael Babker]

Also, remove your config_postgresql.php file from the repo (I'd add it to
the .gitignore so it isn't pushed) this way individual testers can
configure their environments.

[84.le0n]

2012/2/24 Michael Babker <mba...@flbab.com>:

Pushed.

Eng. Gabriele Pongelli.

[Michael Babker]

My test results. It may have to do with me running PG 9.1.1 at the moment
(waiting on my download to finish). Otherwise, no issues.

There was 1 failure:

1) JDatabasePostgresqlTest::testGetCollation
382
Failed asserting that 'C' contains "UTF-8".

/Applications/MAMP/htdocs/joomla-platform/tests/suite/joomla/database/datab
ase/JDatabasePostgresqlTest.php:383
/usr/local/bin/phpunit:46

[84.le0n]

2012/2/24 Michael Babker <mba...@flbab.com>:

> My test results.  It may have to do with me running PG 9.1.1 at the moment
> (waiting on my download to finish).  Otherwise, no issues.
>
> There was 1 failure:
>
> 1) JDatabasePostgresqlTest::testGetCollation
> 382
> Failed asserting that 'C' contains "UTF-8".
>
> /Applications/MAMP/htdocs/joomla-platform/tests/suite/joomla/database/datab
> ase/JDatabasePostgresqlTest.php:383
> /usr/local/bin/phpunit:46
>

I'm running 9.1.1 too .
About your failure, seems that your database's collation isn't based
on UTF-8 , this is why test fails.
What's your collation?
Looking in postgresql's collation table [1] there's not "C" collation.

[1] http://www.postgresql.org/docs/8.1/static/multibyte.html

Eng. Gabriele Pongelli.

[Michael Babker]

OK, the database's collation is C. I'm using pgAdmin3 as my admin
interface and don't see a way to change it when creating databases or
editing them.

[Nikolai Plath]

I would believe that this does not explain the complete failure of the
unit tests..
I get a:
Fatal error: require_once(): Failed opening required '.../tests/suite/
joomla/database/database/JDatabaseExporterPostgreSQLInspector.php'

On 24 Feb., 15:15, Michael Babker <mbab...@flbab.com> wrote:
> OK, the database's collation is C.  I'm using pgAdmin3 as my admin
> interface and don't see a way to change it when creating databases or
> editing them.
>

> On 2/24/12 9:07 PM, "84.le0n" <84.l...@gmail.com> wrote:
>
>
>
>
>
>
>
> >2012/2/24 Michael Babker <mbab...@flbab.com>:

[Michael Babker]

I've run the full test suite and PG test class in isolation and haven't
run into that error.

[Nikolai Plath]

Too bad that there is so little information from Mr(s). joomla-jenkins
about the test results (s)he receives..

On 24 Feb., 15:22, Michael Babker <mbab...@flbab.com> wrote:
> I've run the full test suite and PG test class in isolation and haven't
> run into that error.
>

[84.le0n]

@Nikolai
I've fixed that error, try again now.

@Michael
you can set database encoding during its creation
http://www.postgresql.org/docs/9.1/static/sql-createdatabase.html

Another run of joomla-jenkins with same error, nobody receive same error?

Thanks,
Eng. Gabriele Pongelli

[Nikolai Plath]

Not really..
The file you require:
JDatabaseExporterPostgreSQLInspector.php
The actual file name
JDatabaseExporterPostgresqlInspector.php
So while this works fine on windows, it will not on unixoide
systems.. ;)

On 24 Feb., 18:42, "84.le0n" <84.l...@gmail.com> wrote:
> @Nikolai
> I've fixed that error, try again now.
>
> @Michael

> you can set database encoding during its creationhttp://www.postgresql.org/docs/9.1/static/sql-createdatabase.html

[84.le0n]

2012/2/25 Nikolai Plath <der.e...@gmail.com>:

> Not really..
> The file you require:
> JDatabaseExporterPostgreSQLInspector.php
> The actual file name
> JDatabaseExporterPostgresqlInspector.php
> So while this works fine on windows, it will not on unixoide
> systems.. ;)

Maybe I'm missing some files, it seems to me that I've changed all
filename from "...PostgreSQL..." to "...Postgresql..." and, according
to this, all include and include_once calls were changed.
Am I missing some of them ?

[Nikolai Plath]

Seems fine now - hope we'll see this driver soon in the CMS ;)

On 24 Feb., 20:45, "84.le0n" <84.l...@gmail.com> wrote:
> 2012/2/25 Nikolai Plath <der.el.k...@gmail.com>:

[84.le0n]

Hi Nikolai, I've changed some files according to discussion with Louis
(you can see in pull request page), please run tests again to be sure
these commits works.

Thank you.
Eng. Gabriele Pongelli.