JSimpleCrypt questions

[Paladin]

1) construct function commented as protected, not declared as such.
2) several methods declared with underscore preceding name, but each
one is neither declared as private nor commented as such
3) Property $_key is commented as private but not declared as such.

This affects the way I test the file, so I'm going to assume the
underscored methods and property are private and the construct is not
protected (because if it *is*, then I'm going to have to devise a
completely different way to test it). Let me know if that's wrong.

[Louis Landry]

On Thu, Nov 5, 2009 at 11:12 AM, Paladin <arlen....@gmail.com> wrote:

1) construct function commented as protected, not declared as such.

That is a mistake.  Should be public.

 

2) several methods declared with underscore preceding name, but each
one is neither declared as private nor commented as such

Those should be declared private, yes.

 

3) Property $_key is commented as private but not declared as such.

Should be.

 

This affects the way I test the file, so I'm going to assume the
underscored methods and property are private and the construct is not
protected (because if it *is*, then I'm going to have to devise a
completely different way to test it). Let me know if that's wrong.

Spot on with your assumptions :-)

Louis

 

--
Development Coordinator
Joomla! ... because open source matters.
http://www.joomla.org

[Paladin]

On Nov 5, 11:26 am, Louis Landry <louis.lan...@joomla.org> wrote:

> Spot on with your assumptions :-)

Good to know. I've committed the test file, but...

I couldn't achieve 100% coverage, partly due to the nature of the
beast (you can't always control where the characters occur in an
encrypted string) and partly because _charToInt doesn't seem to be
called anywhere.