JUser Pt5 (save)
0 views
Skip to first unread message
Paladin
Nov 24, 2009, 11:35:53 AM11/24/09
to Joomla! Framework Development
Last quandary to pose to the JUser experts (OK, sit down, enough with
the applause already):
Two problems with the JUser::save method:
Line 523:
$my = &JFactory::getUser();
Calls for a session to start with a getUser call that is not
necessary, as $my is not used anywhere else in the method. At a guess,
it was necessary when the lines 524-537 were not commented out, but it
probably should have been commented out at the same time they were.
Line 543-5:
if ($isnew && $updateOnly) {
return true;
}
Tests to see if it's a new record when we're supposed to be doing only
updates. If it's new, and we can't create a new user it
returns.....true? Shouldn't that be false?
the applause already):
Two problems with the JUser::save method:
Line 523:
$my = &JFactory::getUser();
Calls for a session to start with a getUser call that is not
necessary, as $my is not used anywhere else in the method. At a guess,
it was necessary when the lines 524-537 were not commented out, but it
probably should have been commented out at the same time they were.
Line 543-5:
if ($isnew && $updateOnly) {
return true;
}
Tests to see if it's a new record when we're supposed to be doing only
updates. If it's new, and we can't create a new user it
returns.....true? Shouldn't that be false?
Reply all
Reply to author
Forward
0 new messages