JCache anomaly - coding conventions?

1 view
Skip to first unread message

Paladin

unread,
Nov 24, 2009, 9:09:28 PM11/24/09
to Joomla! Framework Development
The rest of joomla follows the general recipe:

processing
check for error
on error return
normal return

But a lot of the JCache family seems to follow the opposite recipe:

processing
check for error
on no error return
error return

It's a bit of a disconnect, and a problem waiting to happen in
maintenance, as the only real difference on the error check is the
presence/absence of !

Should that be addressed in coding conventions, should it be changed
to be more uniform, or should it just be left alone?

Andrew Eddie

unread,
Nov 25, 2009, 5:29:04 AM11/25/09
to joomla-dev...@googlegroups.com
Sounds odd to me. I'd go for consistency with the rest of the code myself.

Regards,
Andrew Eddie
http://www.theartofjoomla.com - the art of becoming a Joomla developer




2009/11/25 Paladin <arlen....@gmail.com>:
Reply all
Reply to author
Forward
0 new messages