Call for testers, media subpackage in platform

[Rune V. Sjøen]

Hello everyone,

A while back, I expressed some interest in getting media support into
the platform, and learned that this work had already been started by
Louis, so I asked for a copy of his code. Since then I have cleaned it
up, made sure that it works and added some new filters and features.
The code is approaching the point where it would make sense to submit
a pull request to get it into the platform, but before that happens
some testing is needed.

I would encourage anyone that has some time, to clone the repository
at github, my work is on the media branch, and try playing around with
the media functionality in libraries/joomla/media.

https://github.com/rvsjoen/joomla-platform/tree/media

There are still a lot of features to be added, and the unit tests also
needs to be implemented, but I feel that the library functions that
already exists are mature enough for testing.

Cheers,
Rune

[Louis Landry]

Rune,

This is awesome stuff.  Can you get it updated with the current platform and let's start seriously talking about how we can get it pulled into the platform soon?

Thanks again, and my apologies for the ridiculously long wait for a reply.  I wish some of the third party devs out there doing image manipulation (or wanting to) would take it for a spin as well.  

Cheers,

Louis

[Matt Thomson]

Hi Rune,

I will do some testing with this over the next few days, the library
looks great, some initial thoughts after having a quick browse:

Is the library a fork of, or inspired by the wide image library? It
seems to have the same OOP way of loading and manipulating the image.
___

It looks like the 'tofile' functions needs changing to support sites
that use joomlas ftp layer to write, eg this function will fail on
these sites:

imagegif($this->handle, $path);

But this will not:

ob_start();
imagegif($this->handle);
$imageBuffer = ob_get_contents();
ob_end_clean();
JFile::write($path, $imageBuffer);

The coding here seems a bit messy, but I don't know any better way to
avoid writing with straight php.

___

The libra

[Matt Thomson]

....(hit wrong button and posted early).... The library seems to
include lots of filters that are only sometimes used (eg contrast or
emboss) but is missing 3 very widely used functions: watermarking with
an image (merging), watermarking with a font (ttf) file, and rounded
corners.

These functions are done very well in wideimage, it seems it would be
easy to move them over and rewrite them to fit into the library, are
there any plans to do this. I can fork the library and do this on
github if others think it is a good idea.

Matt.

[Rune V. Sjøen]

This thread fell off my radar for a so far unknown reason, sorry about that.
Indeed watermarking and rounding would be very nice to have. If you
would like to fork it
and submit a pull request against my branch, or if you want to wait
until it is merged in the platform
and submit a pull request there, either one is fine by me.

Also, a pull request was recently submitted to the platform. I believe
the best approach
at this point is to get the groundwork pulled, and then look at
extending the feature set.

https://github.com/joomla/joomla-platform/pull/328/files

I also find it a bit complicated to write proper unit tests for the
image processing functions,
so this is something that needs addressing.

- Rune

> --
> You received this message because you are subscribed to the Google Groups "Joomla! Framework Development" group.
> To post to this group, send an email to joomla-dev...@googlegroups.com.
> To unsubscribe from this group, send email to joomla-dev-frame...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/joomla-dev-framework?hl=en-GB.
>
>