JObject::setError optionally take an exception?

[Andrew Eddie]

For 1.6

Would is make sense for JObject::setError to be able to take an
exception so that we can do things like:

catch (JException $e) {
$this->setError($e);
return false;
}

In fact, if it returned false then we could trim that to:

catch (JException $e) {
return $this->setError($e);
}

Thoughts?

Regards,
Andrew Eddie

[Sam Moffatt]

How would getError work in that case? Should it return the exception
or the string?

Sam Moffatt
http://pasamio.id.au

[Andrew Eddie]

The string.

So in setError you'd do:

if ($error instance of Exception) {
$error = $error->getMessage();
}
array_push($this->_errors, $error);
return false;


Regards,
Andrew Eddie



2009/1/28 Sam Moffatt <pas...@gmail.com>:

[Louis Landry]

I can get behind that.  an Exception is certainly an error :)

- Louis

--
Development Coordinator
Joomla! ... because open source matters.
http://www.joomla.org