Bugfixes on Github

91 views
Skip to first unread message

Nils Rückmann

unread,
Mar 24, 2012, 11:45:53 AM3/24/12
to joomla-...@googlegroups.com
After some trouble with sending a bugfix, i'm wondering if there's a current documentation about how we want to
track bugs, add patches, pull request etc...

On docs.joomla.org we only talk about joomlacode.org

Rouven Weßling

unread,
Mar 24, 2012, 11:47:49 AM3/24/12
to joomla-...@googlegroups.com
joomlacode is still the point of truth, anything committed will have to go trough it.

Elin was looking into a replacement tracker (github won't cut it) but I don't know how far she got.

Best regards
Rouven

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/KxU2J9bxfesJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.

Mark Dexter

unread,
Mar 24, 2012, 12:36:30 PM3/24/12
to joomla-...@googlegroups.com
Yes, please use the Joomlacode tracker here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103. Thanks! Mark

elin

unread,
Mar 24, 2012, 1:52:46 PM3/24/12
to joomla-...@googlegroups.com
Mark and I are working on the replacement tracker issue but for now we are still using the current processes although you can add alink to a git hub diff (these work best). However for most of the JBS testers the actual patch file is preferred, so if you would do that it would be awesome in terms of getting things tested.

In ubuntu anyway if you have master as matching the trunk and the branch you are in with your changes you can do
git diff --no-prefix > myfilename.patch


I think we'd like to standardize on no prefix as much as possible.  I would guess even once we have a new tracker many jbs people will prefer patches and thus a good way to get things tested will be to supply patches.

Elin


On Saturday, March 24, 2012 12:36:30 PM UTC-4, Mark Dexter wrote:
On Sat, Mar 24, 2012 at 8:47 AM, Rouven Weßling <m...@rouvenwessling.de> wrote:
joomlacode is still the point of truth, anything committed will have to go trough it.

Elin was looking into a replacement tracker (github won't cut it) but I don't know how far she got.

Best regards
Rouven
On 24.03.2012, at 16:45, Nils Rückmann wrote:

After some trouble with sending a bugfix, i'm wondering if there's a current documentation about how we want to
track bugs, add patches, pull request etc...

On docs.joomla.org we only talk about joomlacode.org

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To view this discussion on the web, visit https://groups.google.com/d/​msg/joomla-dev-cms/-/​KxU2J9bxfesJ.
To post to this group, send an email to joomla-dev-cms@googlegroups.​com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@​googlegroups.com.

For more options, visit this group at http://groups.google.com/​group/joomla-dev-cms?hl=en-GB.

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To post to this group, send an email to joomla-dev-cms@googlegroups.​com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@​googlegroups.com.

Rouven Weßling

unread,
Mar 24, 2012, 2:25:11 PM3/24/12
to joomla-...@googlegroups.com

On 24.03.2012, at 18:52, elin wrote:

I think we'd like to standardize on no prefix as much as possible.  I would guess even once we have a new tracker many jbs people will prefer patches and thus a good way to get things tested will be to supply patches.

According to JM the no prefix patches don't work with Eclipse.

I think we should start considering how to slowly phase out the SVN system. The only thing missing in terms of infrastructure that the SVN repro still offers is the commit mailing list, that'd need be changed.

I wonder how many devs/bug squadder are using SVN vs. git? Maybe a survey would be good.

Rouven

elin

unread,
Mar 24, 2012, 3:08:03 PM3/24/12
to joomla-...@googlegroups.com
They work fine, it is prefixes that cause problems, but the important thing is to standardize one way or the other since it is annoying to have to adjust constantly.

SVN really has nothing to do with it, people are happy and comfortable using it and there is not any particular reason for them to rush to change as long as testing gets done. That's the most important thing, that people who do that work be comfortable.  It's just like all b/c issues :P.

Elin

Hannes Papenberg

unread,
Mar 24, 2012, 3:19:30 PM3/24/12
to joomla-...@googlegroups.com

Maybe with the github api in the platform we could build something that builds the patches automatically from a pull and can be linked into the (new) tracker. Maybe even with a handy overview of all active pulls and their patches...

Hannes

To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/ta2g0h6egbIJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.

Nikolai Plath

unread,
Mar 24, 2012, 3:24:20 PM3/24/12
to joomla-...@googlegroups.com
Well.. GitHub creates patches automagically for every pull request - if they are needed ..

Ian already has created a very simple yet powerful extension for the Joomla! CMS called patchtester that makes testing patches / pull requests a breeze. => https://github.com/ianmacl/patchtester

Depending on the new tracker this could be nicely integrated..
--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/ta2g0h6egbIJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.
--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.

elin

unread,
Mar 24, 2012, 6:53:18 PM3/24/12
to joomla-...@googlegroups.com
All you need to do is put .diff on the end of the pull url and download what you get.

Elin
For more options, visit this group at http://groups.google.com/​group/joomla-dev-cms?hl=en-GB.
--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To post to this group, send an email to joomla-dev-cms@googlegroups.​com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@​googlegroups.com.

El KuKu

unread,
Mar 25, 2012, 3:32:56 PM3/25/12
to Joomla! CMS Development
Yes, that’s what I meant with "automagically" ;)

On 24 Mar, 17:53, elin <elin.war...@gmail.com> wrote:
> All you need to do is put .diff on the end of the pull url and download
> what you get.
>
> Elin
>
>
>
>
>
>
>
> On Saturday, March 24, 2012 3:24:20 PM UTC-4, El KuKu wrote:
>
> >  Well.. GitHub creates patches automagically for every pull request - if
> > they are needed ..
>
> > Ian already has created a very simple yet powerful extension for the
> > Joomla! CMS called patchtester that makes testing patches / pull requests a
> > breeze. =>https://github.com/ianmacl/​patchtester<https://github.com/ianmacl/patchtester>
>
> > Depending on the new tracker this could be nicely integrated..
>
> > Am 24.03.2012 14:19, schrieb Hannes Papenberg:
>
> > Maybe with the github api in the platform we could build something that
> > builds the patches automatically from a pull and can be linked into the
> > (new) tracker. Maybe even with a handy overview of all active pulls and
> > their patches...
>
> > Hannes
> > Am 24.03.2012 18:52 schrieb "elin" <elin.war...@gmail.com>:
>
> >> Mark and I are working on the replacement tracker issue but for now we
> >> are still using the current processes although you can add alink to a git
> >> hub diff (these work best). However for most of the JBS testers the actual
> >> patch file is preferred, so if you would do that it would be awesome in
> >> terms of getting things tested.
>
> >>  In ubuntu anyway if you have master as matching the trunk and the
> >> branch you are in with your changes you can do
> >> git diff --no-prefix > myfilename.patch
>
> >>  I think we'd like to standardize on no prefix as much as possible.  I
> >> would guess even once we have a new tracker many jbs people will prefer
> >> patches and thus a good way to get things tested will be to supply patches.
>
> >>  Elin
>
> >> On Saturday, March 24, 2012 12:36:30 PM UTC-4, Mark Dexter wrote:
>
> >>> Yes, please use the Joomlacode tracker here:http://joomlacode.org/gf/
> >>> project/joomla/tracker/?​​action=TrackerItemBrowse&​ tracker_id=8103<http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBr...>.
> >>> Thanks! Mark
>
> >>> On Sat, Mar 24, 2012 at 8:47 AM, Rouven Weßling <m...@rouvenwessling.de>wrote:
>
> >>>> joomlacode is still the point of truth, anything committed will have to
> >>>> go trough it.
>
> >>>>  Elin was looking into a replacement tracker (github won't cut it) but
> >>>> I don't know how far she got.
>
> >>>>  Best regards
> >>>>  Rouven
>
> >>>>  On 24.03.2012, at 16:45, Nils Rückmann wrote:
>
> >>>>  After some trouble with sending a bugfix, i'm wondering if there's a
> >>>> current documentation about how we want to
> >>>> track bugs, add patches, pull request etc...
>
> >>>> On docs.joomla.org we only talk about joomlacode.org
>
> >>>>  --
> >>>> You received this message because you are subscribed to the Google
> >>>> Groups "Joomla! CMS Development" group.
> >>>> To view this discussion on the web, visithttps://groups.google.com/d/
> >>>> ​msg/joomla-dev-cms/-/​​KxU2J9bxfesJ<https://groups.google.com/d/msg/joomla-dev-cms/-/KxU2J9bxfesJ>
> >>>> .
> >>>> To post to this group, send an email to joomla-dev-cms@googlegroups.
> >>>> ​com <joomla-...@googlegroups.com>.
> >>>> To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@
> >>>> ​googlegroups.com <joomla-dev-cm...@googlegroups.com>.
> >>>> For more options, visit this group athttp://groups.google.com/
> >>>> ​group/joomla-dev-cms?hl=en-GB<http://groups.google.com/group/joomla-dev-cms?hl=en-GB>
> >>>> ​.
>
> >>>>    --
> >>>> You received this message because you are subscribed to the Google
> >>>> Groups "Joomla! CMS Development" group.
> >>>> To post to this group, send an email to
> >>>> joomla-dev-cms@googlegroups.​​com <joomla-...@googlegroups.com>.
> >>>> To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@​
> >>>> googlegroups.com <joomla-dev-cms%2Bunsu...@googlegroups.com>.
> >>>> For more options, visit this group athttp://groups.google.com/
> >>>> group/joomla-dev-cms?hl=en-GB<http://groups.google.com/group/joomla-dev-cms?hl=en-GB>
> >>>> .
>
> >>>  --
> >> You received this message because you are subscribed to the Google Groups
> >> "Joomla! CMS Development" group.
> >> To view this discussion on the web, visit
> >>https://groups.google.com/d/​msg/joomla-dev-cms/-/​ta2g0h6egbIJ<https://groups.google.com/d/msg/joomla-dev-cms/-/ta2g0h6egbIJ>
> >> .
> >> To post to this group, send an email to joomla-dev-cms@googlegroups.​com<joomla-...@googlegroups.com>
> >> .
> >> To unsubscribe from this group, send email to
> >> joomla-dev-cms+unsubscribe@​googlegroups.com<joomla-dev-cms%2Bunsu...@googlegroups.com>
> >> .
> >> For more options, visit this group at
> >>http://groups.google.com/​group/joomla-dev-cms?hl=en-GB<http://groups.google.com/group/joomla-dev-cms?hl=en-GB>
> >> .
>
> >  --
> > You received this message because you are subscribed to the Google Groups
> > "Joomla! CMS Development" group.
> > To post to this group, send an email to joomla-dev-cms@googlegroups.​com<joomla-...@googlegroups.com>
> > .
> > To unsubscribe from this group, send email to
> > joomla-dev-cms+unsubscribe@​googlegroups.com<joomla-dev-cm...@googlegroups.com>
> > .
> > For more options, visit this group at
> >http://groups.google.com/​group/joomla-dev-cms?hl=en-GB<http://groups.google.com/group/joomla-dev-cms?hl=en-GB>
> > .
Reply all
Reply to author
Forward
0 new messages