Hardcoded punctuation creates issues in language files

246 views
Skip to first unread message

infograf768

unread,
May 30, 2009, 1:19:50 PM5/30/09
to Joomla! CMS Development
In 1.5 we have quite a few punctation marks that are hardcoded and
therefore not included in the JText strings.
This creates issues in some languages.
Example:

<label for="username">
<?php echo JText::_( 'User Name' ); ?>:
</label>

String is
USER NAME=Username

This forces for example in French to add an &nbsp; at the end of the
string as ":" has to be separated from the word before.
In some languages, ":" is never used.
etc.

Is it possible to take this remark into account for 1.6?

Louis Landry

unread,
May 30, 2009, 1:52:35 PM5/30/09
to joomla-...@googlegroups.com
All we need is a patch to apply and that can be fixed.

Cheers,
Louis
--
Development Coordinator
Joomla! ... because open source matters.
http://www.joomla.org

Andrew Eddie

unread,
May 31, 2009, 4:11:34 AM5/31/09
to joomla-...@googlegroups.com
JM, I suggest you change the key to:

USER_NAME_LABEL=User Name:

Or, we remove the colons.

Regards,
Andrew Eddie
http://www.theartofjoomla.com - the art of becoming a Joomla developer




2009/5/31 infograf768 <infog...@gmail.com>:

ot2sen

unread,
May 31, 2009, 5:31:46 AM5/31/09
to joomla-...@googlegroups.com
Good one JM.
 
We certainly would want to get rid of those hardcoded colons at for example the user register template, and instead make it optional in the translated string.
 
Andrews suggestion seems like a good replacement. Strip out the hardcoded colon and add it to the translateable string instead.
 
You just assigned yourself for some patching ;p
 
Ole

infograf768

unread,
May 31, 2009, 10:28:01 AM5/31/09
to Joomla! CMS Development
No problem concerning creating a patch, if I find where these are in
1.6 ;)
Will look.
My post was more to ask devs to remember that kind of issues when
coding 1.6.

On 31 May, 11:31, ot2sen <ot2...@gmail.com> wrote:
> Good one JM.
>
> We certainly would want to get rid of those hardcoded colons at for example
> the user register template, and instead make it optional in the translated
> string.
>
> Andrews suggestion seems like a good replacement. Strip out the hardcoded
> colon and add it to the translateable string instead.
>
> You just assigned yourself for some patching ;p
>
> Ole
>
> On Sun, May 31, 2009 at 10:11 AM, Andrew Eddie <mambob...@gmail.com> wrote:
>
> > JM, I suggest you change the key to:
>
> > USER_NAME_LABEL=User Name:
>
> > Or, we remove the colons.
>
> > Regards,
> > Andrew Eddie
> >http://www.theartofjoomla.com- the art of becoming a Joomla developer
>
> > 2009/5/31 infograf768 <infograf...@gmail.com>:
Reply all
Reply to author
Forward
0 new messages