New Plugin

172 views
Skip to first unread message

Shai Ben-Hur

unread,
Aug 14, 2012, 5:01:10 AM8/14/12
to jenkin...@googlegroups.com

Hi,

I wrote a new plugin called "Template Workflows", you can read all about it here:
https://wiki.jenkins-ci.org/display/JENKINS/Template+Workflows+Plugin
I would like to host it in gitHub, here is my id: shaibe

Thanks,
Shai

nicolas de loof

unread,
Aug 14, 2012, 5:22:59 AM8/14/12
to jenkin...@googlegroups.com
please create a repo on https://github.com/shaibe and push plugin code, I'll then fork it on jenkinsci account

I wonder if we could collaborate to merge this plugin with or depend upon my Build Flow plugin (https://wiki.jenkins-ci.org/display/JENKINS/Build+Flow+Plugin), as they seem to focus on same use-case

2012/8/14 Shai Ben-Hur <shai...@gmail.com>

Shai Ben-Hur

unread,
Aug 14, 2012, 5:47:29 AM8/14/12
to jenkin...@googlegroups.com

Hi Nicolas,

Indeed we are focusing on the same use case. What kind of collaboration did you have in mind?

BTW, i already checked and my plugin is compatible with yours:

You can define a build flow job - mark it as a template and place some parameter pattern => you'll get a nice UI with my plugin to create build flow jobs:

 Shai

nicolas de loof

unread,
Aug 14, 2012, 5:51:10 AM8/14/12
to jenkin...@googlegroups.com
interesting. So your plugin is more about creating templates to simplify workflow configuration, with few parameters and UI candy.
I'd be pleased to look how you manage jobs orchestration, as this is the most annoying part of build flow plugin today. I'd like it to be "continuable", so a flow can restart after some job have completed, either due to jenkins restart, or manual re-trigger after some step failure, etc. Today this is only a basic Job.schedule() orchestrator. Maybe will require me to improve my groovy skills :)

2012/8/14 Shai Ben-Hur <shai...@gmail.com>

Shai Ben-Hur

unread,
Aug 14, 2012, 6:18:17 AM8/14/12
to jenkin...@googlegroups.com
My plugin is all about "template workflow" definitions and how easy it is to create and manage a workflow from a template.
The plugin uses jenkins existing plugins in order to do that, so whatever can be accomplished using a regular jobs chaining and plugins configuration can be placed under a "template workflow" and could be created/ edit/ deleted/ execute all using custom parameters.

Sounds interesting this "continuable" concept... I'm not handling it simply cause its not supported in jenkins core and no one wrote a plugin to do that.

I will create the repo and upload my code later, so you could have a look.

Shai

shai bhur

unread,
Aug 15, 2012, 1:39:05 AM8/15/12
to jenkin...@googlegroups.com
Hi,

Guess I can't release it until you fork it to  jenkinsci account - right?

Shai

nicolas de loof

unread,
Aug 15, 2012, 2:25:10 AM8/15/12
to jenkin...@googlegroups.com

shai bhur

unread,
Aug 15, 2012, 3:04:34 AM8/15/12
to jenkin...@googlegroups.com
Thanks for that Nicolas.
When I'm trying to release my plugin in hangs on the maven release with this line:
[INFO] Executing: cmd.exe /X /C "git push ssh://shaib:****@github.com/jenkinsci/template-workflows-plugin.git master:master"
[INFO] Working directory: E:\gitHub\template-workflows-jenkins-plugin

any idea?

shai bhur

unread,
Aug 15, 2012, 4:57:29 AM8/15/12
to jenkin...@googlegroups.com
Hey Nicolas, I need some help uploading my plugin...
I'm using windows (don't ask...) and the maven release fails on github authentication.

Im getting the same behavior from my shell (cmd):

C:\Documents and Settings\shaib\.ssh>ssh -T g...@github.com
Hi shaibe! You've successfully authenticated, but GitHub does not provide shell access.


E:\gitHub\template-workflows-jenkins-plugin>git push ssh://shaibe:shai***@github.com/jenkinsci/template-workflows-plugin.git master:master
Permission denied (publickey).
fatal: The remote end hung up unexpectedly

Which user and pw should I use? the github or the jenkins?
Do you have any suggestions (besides switching to unix)? 

nicolas de loof

unread,
Aug 15, 2012, 5:16:56 AM8/15/12
to jenkin...@googlegroups.com
don't use ssh://shaibe:shai***@github.com/jenkinsci/template-workflows-plugin.git but ssh://git@github.com/jenkinsci/template-workflows-plugin.git

you're identified/authenticated on github by your ssh key, and all git commands connect as "git"

2012/8/15 shai bhur <shai...@gmail.com>

shai bhur

unread,
Aug 15, 2012, 5:37:25 AM8/15/12
to jenkin...@googlegroups.com
Thanks for the quick response, now i'm getting this:

E:\gitHub\template-workflows-jenkins-plugin>git push ssh://g...@github.com/jenkinsci/template-workflows-plugin.git master:master
ERROR: Permission to jenkinsci/template-workflows-plugin.git denied to shaibe.
fatal: The remote end hung up unexpectedly

also, the maven release generated the ssh with my user and pw, should i remove the user and pw parameters?

Shai

nicolas de loof

unread,
Aug 15, 2012, 6:24:05 AM8/15/12
to jenkin...@googlegroups.com
the command you pass is wrong. 

git remote add jenkins g...@github.com:jenkinsci/template-workflows-plugin.git
then
git push jenkins master


or, if you don't care to keep your own repository, just 

git push origin master

for maven release, remove user / password from URL and delete related commits from your git history before pushing


2012/8/15 shai bhur <shai...@gmail.com>

shai bhur

unread,
Aug 15, 2012, 6:34:39 AM8/15/12
to jenkin...@googlegroups.com
still not working:

E:\gitHub\template-workflows-jenkins-plugin>git remote add jenkins g...@github.com:jenkinsci/template-workflows-plugin.git

E:\gitHub\template-workflows-jenkins-plugin>git push jenkins master
ERROR: Permission to jenkinsci/template-workflows-plugin.git denied to shaibe.
fatal: The remote end hung up unexpectedly


Shai Ben-Hur

unread,
Aug 15, 2012, 8:13:01 AM8/15/12
to jenkin...@googlegroups.com
Hey Nicolas,

I can see that i have "read-only" access to "https://github.com/jenkinsci/template-workflows-plugin.git". 
Could this be related to the "permission denied" issue? shouldn't i have write access as well?

I'll really appreciate your help, 
Shai

nicolas de loof

unread,
Aug 15, 2012, 9:27:03 AM8/15/12
to jenkin...@googlegroups.com
fixed
please try again

2012/8/15 Shai Ben-Hur <shai...@gmail.com>

shai bhur

unread,
Aug 15, 2012, 9:57:13 AM8/15/12
to jenkin...@googlegroups.com
ok... now it worked and i was able to connect to github - thanks!!!
BUT - the maven release failed with:
[INFO] ------------------------------------------------------------------------
[INFO] [ERROR] BUILD ERROR
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] 

i'm starting to think that it was easier to write the plugin than uploading it :)

Shai

nicolas de loof

unread,
Aug 15, 2012, 11:13:52 AM8/15/12
to jenkin...@googlegroups.com
do you have credentials configured in your settings.xml for the distributionManagement server ? 

2012/8/15 shai bhur <shai...@gmail.com>

shai bhur

unread,
Aug 15, 2012, 2:05:04 PM8/15/12
to jenkin...@googlegroups.com
Hey Nicolas,

Finally... I was able to successfully run the maven release - THANKS a lot for your help!

Few questions:
1) during the attempt to release the plugin i had to increase the plugin version and its currently at v:1.2, is there a way to delete tags 1.0, 1.1, 1.2 so i can re-release it with its real version -1.0?
2) when will it be available to download and installation from the update center?
3) who is responsible to update the wiki and announce that this plugin is released?
4) when will the wiki page be updated with the plugin info header?
5) if you could find the time to install this plugin, i will really appreciate your feedback on it.

Again,
Thanks a lot
Shai

nicolas de loof

unread,
Aug 15, 2012, 3:37:03 PM8/15/12
to jenkin...@googlegroups.com


2012/8/15 shai bhur <shai...@gmail.com>
Hey Nicolas,

Finally... I was able to successfully run the maven release - THANKS a lot for your help!

Few questions:
1) during the attempt to release the plugin i had to increase the plugin version and its currently at v:1.2, is there a way to delete tags 1.0, 1.1, 1.2 so i can re-release it with its real version -1.0?

sure you can (http://nathanhoad.net/how-to-delete-a-remote-git-tag) or just don't spend time and look at 1.3 for next one :)
 
2) when will it be available to download and installation from the update center?

some hours. Depends on a periodic task, ran every 8 hours afaik
 
3) who is responsible to update the wiki and announce that this plugin is released?

you have to update the wiki (but the plugin-info header) with changelog, etc. Announcement is also automated ... in some hours :D
 
4) when will the wiki page be updated with the plugin info header?

some hours :D 

5) if you could find the time to install this plugin, i will really appreciate your feedback on it.

can't promise, so much things to do before vacation next week :-/

shai bhur

unread,
Aug 16, 2012, 2:21:02 AM8/16/12
to jenkin...@googlegroups.com
Hi Nicolas,

I can see that the plugin info header changed and that the wiki announces my plugin. But I can't find it in the update center...
I can't find it in the update center json file: http://ftp-nyc.osuosl.org/pub/jenkins/updates/update-center.json

Who should I contact regarding this issue? Or should I just wait?

Thanks,
Shai

nicolas de loof

unread,
Aug 16, 2012, 2:23:50 AM8/16/12
to jenkin...@googlegroups.com
it's there now
be patient :)

2012/8/16 shai bhur <shai...@gmail.com>

shai bhur

unread,
Aug 16, 2012, 2:36:07 AM8/16/12
to jenkin...@googlegroups.com
Thanks man :)

shai bhur

unread,
Aug 16, 2012, 4:44:40 AM8/16/12
to jenkin...@googlegroups.com
Hey Nicolas,
I don't want to be a nagger... but my plugin still not available in the update center and now it won't show up in  the wiki "new releases".
Does it usually take this much time? 

Thanks,
Shai

shai bhur

unread,
Aug 16, 2012, 5:00:54 AM8/16/12
to jenkin...@googlegroups.com
Ok. its there now. the wiki still not announcing my plugin though...

Frederik Fromm

unread,
Aug 16, 2012, 5:23:12 AM8/16/12
to jenkin...@googlegroups.com
just edit the wiki page. Sometimes this triggers the plugin data update.

2012/8/16 shai bhur <shai...@gmail.com>

shai bhur

unread,
Aug 16, 2012, 6:07:14 AM8/16/12
to jenkin...@googlegroups.com
Thanks. it's still not there. I'll wait...
Reply all
Reply to author
Forward
0 new messages