PEP8 compliance patch

6 views
Skip to first unread message

Matěj Cepl

unread,
May 28, 2012, 9:18:44 AM5/28/12
to jbr...@googlegroups.com
Hi,

http://code.google.com/p/jbrout/issues/detail?id=204

OK, once more I have created a patch making jbrout (more or less) PEP8
compliant. This time it is purely manual work (vim + pep8 in the command
line) and I have checked that it applies cleanly on the top of the
current trunk. It contains only PEP-8 related changes, and even when I
saw things which should be improved, I haven't touch them to keep this
simple (albeit huge).

I don't envy you reviewing of this patch, but OTOH it shouldn't be more
difficult than creating it in the first place ;).

Let me add couple of notes what went through my mind when working on the
patch:

1) we really should accept existence of reliable VCS (even SVN would
hopefully qualify, but I would prefer git) and remove all commented out
code. Readability and maintainability would increase significantly with
just a little effort.
2) Whole program really cries for splitting up in smaller modules.
Mastodonts like db.py (1179 lines), listview.py (830), tools.py (741),
or especially jbrout.py itself (3250 lines) are just on the limits of
maintainability. But that's much work, so it can wait for later.

Looking forward to your complaints about the patch.

Matěj
--
http://www.ceplovi.cz/matej/, Jabber: mcepl<at>ceplovi.cz
GPG Finger: 89EF 4BC6 288A BF43 1BAB 25C3 E09F EF25 D964 84AC

- Do you think of yourself as a Christian artist?
- I'm an artist who is a Christian. I'm not a Christian artist.
-- Johny Cash
in his last interview

0001-Reformat-to-PEP-8-compliance.patch
Reply all
Reply to author
Forward
0 new messages