Inverted graphical bar charts on 2.2.0?

[Renato Garcia]

Hi Guys,

I've upgraded EclEmma to 2.2.0 (very nice btw, thanks!) but it seems that the graphical bars are inverted? The green part is now on the left instead of right? Is this on purpose?

Also, is it possible to somehow configure the look of the bars to look more like the original one? Very silly request, I know, but I find the old look! Sorry for the late feedback, I missed the preview release.

Thanks again!

[Marc Hoffmann]

Ciao Renato,

thanks for your feedback! Your observation is correct, I aligned the
EclEmma coverage view with the look&feel of the JaCoCo reports. JaCoCo
reports show uncovered code first. Bar lengths represent the absolute
amount within the same group.

Configuration is currently not possible. May I ask you about your use
case of your request or is it a visual issue only (that can also be
fixed of course).

Best regards,
-marc

> --

[Renato Garcia]

Hi Marc,

I see, it makes sense. There is no specific use case. We are still not
using JaCoCo on the CI build, so I'm not used to the style of the JaCoCo
reports, but it think that it is beneficial to have both of them using
the same style of reporting. Is there a reason JaCoCo reports show
uncovered code first, or it is just a matter of taste? I personally find
going from green to red more intuitive as we usually start from 0 and
increase as we go, giving the idea of progress (and maybe because I've
been using Eclmma too).

Regarding the appearance, independently from the style of reporting, I
think that new bar doesn't look as good as the older used to look when
inside eclipse. They don't match very well with eclipse look and colors.
Maybe having some options to configure the appearance of the bar would
be nice, and perhaps have it with some pre defs like Classic and JaCoCo
appearence.

Regards,
Renato

[Marc Hoffmann]

Hi Renato,

> Is there a reason JaCoCo reports show uncovered code first,
> or it is just a matter of taste?

Yes there is: The idea if code coverage analysis is to find and focus
on the untested code. That's why JaCoCo reports allways show untested
code figures first. Here is an example:
http://www.eclemma.org/jacoco/trunk/coverage/

Regarding the appearance I'm open for alternative proposals. You can
provide for example a mockup.

Best regards,
-marc

[Renato Garcia]

On 13/11/12 20:40, Marc Hoffmann wrote:
> Hi Renato,
>
>> Is there a reason JaCoCo reports show uncovered code first,
>> or it is just a matter of taste?
>
> Yes there is: The idea if code coverage analysis is to find and focus
> on the untested code. That's why JaCoCo reports allways show untested
> code figures first. Here is an example:
> http://www.eclemma.org/jacoco/trunk/coverage/

It's an interesting perspective. In this case shouldn't the percentage
values reflect the untested code then?

>
> Regarding the appearance I'm open for alternative proposals. You can
> provide for example a mockup.

I think that the original bar looks good on Eclipse. Why not just use it
as a reference?

[Renato Garcia]

Hi Marc,

Sorry for the delay, but here is how it is looking. I can create a pull request for this if you like. There's also a setting on the preference page that allows your to choose the preferred style, between JaCoCo reports and EclEmma.

Regards,
Renato