[izpack-dev] dir / file fields' behavior on not-existing files

[Kjell Braden]

Hi all,

currently, we have an open bug (IZPACK-465, [1]) about our dir fields in
UserInputPanels. If mustExist="false" was specified and a non-existing
path is selected the installer warns the user that it would create the
directory (TargetPanel.createdir message) - but there is no code that
does that, so the directory would not actually be created.

I'm wondering now if automatically creating the directory is actually
desirable / intended. Any objections to create a new attribute "create"
to dir-fields' spec element?

Another point is how to handle that case (mustExist=false and does not
exist) for file fields? Should we create an empty file? Or nothing at all?

[1] http://jira.codehaus.org/browse/IZPACK-465

-Kjell

[Kjell Braden]

Kjell Braden schrieb:

> Another point is how to handle that case (mustExist=false and does not
> exist) for file fields? Should we create an empty file? Or nothing at all?
>

Woops, just noticed that file fields don't have the mustExist attribute
at all. I'll make that more clear in the code.

[Julien Ponge]

Hi Kjell,

> I'm wondering now if automatically creating the directory is actually
> desirable / intended. Any objections to create a new attribute "create"
> to dir-fields' spec element?

Sounds good.

> Another point is how to handle that case (mustExist=false and does not
> exist) for file fields? Should we create an empty file? Or nothing at all?

I would say nothing at all since mustExist=false should probably be
understood as "that's fine if it doesn't exist".

Cheers

--
http://izpack.org/
http://jpz-log.info/
http://julien.ponge.info/

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

[Dennis Reil]

mustExist was originally intended to choose an existing directory. Thus if
the directory doesn't exist, I would expect a message that you have to
choose an existing directory.

I thought we already have something for creating the directory.

Regards,
Dennis