[izpack-dev] exec-admin in Uninstaller

[Kjell Braden]

Hi,

currently, the exec-admin flag for the uninstaller will only be set when
the installer has elevated itself (see .installer.UnpackerBase line
742). I have some use cases where the user manually elevates the
installer (e.g. an .exe wrapper with "installer" in it's file name,
get's elevated manually) and isPrivilegedMode() would return false.

I suggest to remove the check on PrivilegedRunner.isPrivilegedMode() and
always let the uninstaller elevate when <run-privileged/> is set.

-Kjell

[Julien Ponge]

Or maybe we could make it configurable, just like for the installer?

What do you think?

Cheers

--
http://izpack.org/
http://jpz-log.info/
http://julien.ponge.info/

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

[Kjell Braden]

Julien Ponge wrote:
> Or maybe we could make it configurable, just like for the installer?
>
> What do you think?
>
> Cheers
>

Sounds good, JIRA created, patch submitted:
http://jira.codehaus.org/browse/IZPACK-430

I didn't commit yet because I was unable to fully test it for now. (feel
free...)

-Kjell

[Julien Ponge]

I just had a look and it sounds good, so you can commit :-)

BTW I had a look at another JIRA issue that you assigned back to me
and you can commit too!

Thanks

--

[Julien Ponge]

That was IZPACK-423 :-)

[Kjell Braden]

Julien Ponge wrote:
> I just had a look and it sounds good, so you can commit :-)
>
> BTW I had a look at another JIRA issue that you assigned back to me
> and you can commit too!
>
> Thanks
>

Done, thanks!

-Kjell

[Julien Ponge]

You killed the build :-) http://bamboo.ci.codehaus.org/browse/IZPACK-TRUNK-162

--

[Kjell Braden]

Julien Ponge wrote:
> You killed the build :-) http://bamboo.ci.codehaus.org/browse/IZPACK-TRUNK-162
>

Woops... fixed, thanks