binary options bug

[Holger Schinzel]

Hello Christian,

i noticed a bug in your compiler-wrapper design. You are using

> // add in binary options.
> if (optimize) javaParms.add("-compiler.optimize");
> if (profile) javaParms.add("-compiler.profile");
> if (strict) javaParms.add("-compiler.strict");
> if (useNetwork) javaParms.add("-use-network");
> if (warnings) javaParms.add("-warnings");
> if (incremental) javaParms.add("-compiler.incremental");
> if (showActionscriptWarnings)
> javaParms.add("-show-actionscript-warnings");
> if (showBindingWarnings) javaParms.add("-show-binding-warnings");
> if (showDeprecationWarnings)
> javaParms.add("-show-deprecation-warnings");

for adding in the binary options. The problem is that some of the mxmlc
options have a default value of "true" [1]. Because of that, setting
these properties (e.g. useNetwork) to "false" in the pom will not work
as expected.

A patch would be to add the options with

> javaParms.add("-use-network=" + useNetwork);

as you did for the "debug" option as well.

Please keep on working on this very useful project :-)

kind regards,
Holger

[1] http://livedocs.adobe.com/flex/2/docs/00001500.html#157203