Issue 54 in innotop: Toggling display of idle connections in Query mode not working in 1.8.0.

[inn...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 54 by mag...@gmail.com: Toggling display of idle connections in
Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

What steps will reproduce the problem?

1. Load innotop-1.8.0 in default/Q mode.
2. Make some connections to the server other shells.
3. Pres 'i'.

What is the expected output? What do you see instead?

When pressing 'i' in Q mode the idle connections should be shown/not shown.
But nothing happens.

What version of the product are you using? On what operating system?

* innotop-1.8.0 on Gentoo Linux.

* Tested against Percona Server 5.5.18-r23.0 and 5.1.55-r12.6.

Please provide any additional information below.

Toggling idle/non-idle transactions in T mode with 5.1.55-r12.6 does seem
to work. I was unable to test that with 5.5.18-r23.0 because innotop-1.8.0
crashes in T and L modes against that version (there is another ticket open
for that).

[inn...@googlecode.com]

Comment #1 on issue 54 by baron.sc...@gmail.com: Toggling display of idle

connections in Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

There is more than one filter applied to this table. It is likely that one
of these other filters is hiding what you consider to be idle:
hide_slave_io hide_event hide_inactive hide_self

You can press ^, then f to show the filters active on the table, and you
can remove all of them and see if that shows what you want to see.

[inn...@googlecode.com]

Comment #2 on issue 54 by mag...@gmail.com: Toggling display of idle

connections in Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

Okay, it seems the problem is the hide_event filter. That filter is
defined thus:

hide_event => {
text => <<' END',
return (($set->{state} || '') !~ m/^Daemon/) && (($set->{info} |
| '') =~ m/\S/);
END
note => 'Removes idle event threads from the list',
tbls => [qw(processlist)],
},

So, you want to filter out threads that have a state field beginning
with 'Daemon' and a clear (not set or only white space) info field, letting
anything else through.

Filter out: state is Daemon and info is clear

(($set->{state} || '') =~ m/^Daemon/) && (($set->{info} || '') =~ m/\S/)

negate that:

!((($set->{state} || '') =~ m/^Daemon/) && (($set->{info} || '') =~ m/\S/))

reduce that:

(($set->{state} || '') !~ m/^Daemon/) || (($set->{info} || '') !~ m/\S/)

[inn...@googlecode.com]

Updates:
Status: Accepted

Comment #3 on issue 54 by baron.sc...@gmail.com: Toggling display of idle

connections in Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

It's clear now -- thanks.

[inn...@googlecode.com]

Comment #4 on issue 54 by baron.sc...@gmail.com: Toggling display of idle

connections in Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

BTW, before I make this change, can you confirm that it does fix the issue
for you?

[inn...@googlecode.com]

Comment #5 on issue 54 by mag...@gmail.com: Toggling display of idle

connections in Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

Baron,

I'm sorry, I didn't see this your last reply before. Yes, changing that
line of code to what I worked out allows normal inactive connections to be
seen and toggled when the hide_event filter is on.

[inn...@googlecode.com]

Updates:
Status: Fixed

Comment #6 on issue 54 by baron.sc...@gmail.com: Toggling display of idle

connections in Query mode not working in 1.8.0.
http://code.google.com/p/innotop/issues/detail?id=54

This issue was closed by revision r92.