Updated Issue 165 - Multiple SSH keys per user (indefero)
no-r...@ceondo.com
The following issue has been updated:
165 - Multiple SSH keys per user
Project: InDefero
Status: New
Reported by: Ciaran Gultnieks
URL: http://projects.ceondo.com/p/indefero/issues/165/
Labels:
Priority:High
Type:Enhancement
Comments (last first):
# By Robbie Trencheny, Dec 18, 2009:
any update on this? the patch no longer works :(
# By Tim Wang, Aug 30, 2009:
just show my support for this feature. When will you implement this to the hosted edition?
# By Andrew Nguyen, Jul 15, 2009:
Would you like me to make this change and resubmit a patch?
# By Loïc d'Anterroches, Jul 15, 2009:
This is good. You can even replace:
$request->user->setMessage(__('Attempting to delete key owned by another user'));
with:
return new Pluf_HTTP_Response_Forbidden($request);
The loginRequired precondition is only checking that the user is effectively signed in and is not anonymous.
Thanks a lot for the nice comments about Pluf, you are making my day.
# By Andrew Nguyen, Jul 14, 2009:
Not sure if this is good enough or the proper way. I must say Pluf seems pretty easy to work with - since I have no prior PHP experience.
Attachments:
- Check_useer_before_delete_sshkey.patch - 915 bytes
http://projects.ceondo.com/p/indefero/issues/view/attachment/71/Check_useer_before_delete_sshkey.patch
# By Andrew Nguyen, Jul 14, 2009:
Good to know - I assumed (without looking into it at all) that the loginRequired precondition verified that implicitly.
I will fix that.
# By Loïc d'Anterroches, Jul 14, 2009:
Andrew, in your delete key view, you are not checking that the key belongs to the user doing the request. Any signed in user can drop any key.
# By Loïc d'Anterroches, Jul 14, 2009:
This is great Andrew, I will check that as soon as possible!
# By Andrew Nguyen, Jul 14, 2009:
Forgot to add new files in the above patch
Attachments:
- 0002-Forgot-to-add-Form-and-Migration-files.patch - 6.43 kB
http://projects.ceondo.com/p/indefero/issues/view/attachment/70/0002-Forgot-to-add-Form-and-Migration-files.patch
# By Andrew Nguyen, Jul 14, 2009:
Not sure where you are with this but I desperately needed this today and have coded up another patch.
I decided to modify the schema a little and added a column for a short description of the key - otherwise I had no idea which key went where when considering to delete one.
It is attached in case you're interested in it.
Attachments:
- 0001-Added-multiple-SSH-key-support.patch - 13.08 kB
http://projects.ceondo.com/p/indefero/issues/view/attachment/69/0001-Added-multiple-SSH-key-support.patch
# By Loïc d'Anterroches, Jul 10, 2009:
It should be possible to have deploy keys with read only rights.
Labels: Priority:High, -Priority:Medium
# By Vedang Manerikar, Jun 25, 2009:
Hi guys,
joined indefero today and was immediately hindered by lack of multiple ssh keys. Can you give me an idea as to when this issue will be resolved?
# By Sindre Myren, Apr 13, 2009:
Just want to add my support for this issue.
# By Loïc d'Anterroches, Mar 26, 2009:
Yes, this is planned and already requested in issue 147 (in French so I understand you haven't found it).
Labels: Type:Enhancement, -Type:Defect
# By Ciaran Gultnieks, Mar 24, 2009:
Multiple SSH keys per user should be allowed (as per gitosis and gitorious, for example).
It looks like the database is already structured to support this, so perhaps it is just a case of the additional web site UI?
--
Issue: http://projects.ceondo.com/p/indefero/issues/165/
no-r...@ceondo.com
The following issue has been updated:
165 - Multiple SSH keys per user
Project: InDefero
Status: New
Reported by: Ciaran Gultnieks
URL: http://projects.ceondo.com/p/indefero/issues/165/
Labels:
Priority:High
Type:Enhancement
Comments (last first):
# By Denis Kot, Dec 23, 2009:
my vote for this!