Automate record creation in temp tables

[Alexander Obuhovich]

I propose we move code

if ($object->IsTempTable()) {
    $object->setTempID();
}

into kDBItem::Create method, so when sub-item is being create in temp table, then it's ID is automatically assigned.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Alexander Obuhovich]

Also, when using temp tables and you are in OnAfterItemCreate method, then $object->GetID() will return 0 instead of -1/-2/etc., because setTempID() is called after kDBItem::Create() method is executed completely.

[Dmitry A.]

Any possible implications if we removed that?

if ($object->IsTempTable()) {
$object->setTempID();
}

DA.

On Feb 11, 9:52 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> Also, when using temp tables and you are in OnAfterItemCreate method, then
> $object->GetID() will return 0 instead of -1/-2/etc., because setTempID() is
> called after kDBItem::Create() method is executed completely.
>

> On Thu, Feb 11, 2010 at 5:20 PM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
> > I propose we move code
>

> > *if ($object->IsTempTable()) {
> >     $object->setTempID();
> > }
> > *

[Alexander Obuhovich]

We don't remove, we move it up into deeper code, what calls OnAfterItemCreate. Implications would be if you miss to add it in your own code.

[Dmitry A.]

Great - would you please upload the patch so we can review and test
it as a bug then.

DA.

[Alexander Obuhovich]

Here is the task: http://tracker.in-portal.org/view.php?id=617

[Alexander Obuhovich]

Here is the task: http://tracker.in-portal.org/view.php?id=617