3rd refactoring of Shipping Quote Engines related to USPS

[Alexander Obuhovich]

We have method, named "MakeUSPSOrder" in OrderEventHandler class. This not good, since we have separate class for USPS interaction code.

I propose to create universal method MakeOrder in each SQE (ShippingQuoteEngine) and move MakeUSPSOrder to one of them. This way we will determine SQE by shipping type used in order and delegate all specific processing to it.

Task: http://tracker.in-portal.org/view.php?id=871

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Dmitry Andrejev]

Hi Alex,

I have ran some tests on 5.1.x (5.1.1-B1).

like we need some work.

For some reason we never got to "MakeOrder" with USPS. See part of the DEBUG occurred during Ship Order action.

Let me know if you want access to my test site.

DA.

--

Best regards,

Dmitry A.

[Alexander Obuhovich]

Have you tried order approving? Did it called MakeOrder then?

[Dmitry Andrejev]

No, it haven't called the method... at least it didn't get inside of it.

Let me know what's next. I can actually give you the account info and you can try run this from your development.

DA.

[Alexander Obuhovich]

Agreed, give it to me (maybe in private email).

[Alexander Obuhovich]

New patch attached (in task too).

[Dmitry A.]

It was tested good and was included in 5.1.1 Beta1

DA.

On Sep 26, 6:00 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> New patch attached (in task too).
>

> On Fri, Sep 24, 2010 at 9:29 AM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
>
>
>
>
> > Agreed, give it to me (maybe in private email).
>

> > On Thu, Sep 23, 2010 at 11:13 PM, Dmitry Andrejev <dandre...@gmail.com>wrote:
>
> >> No, it haven't called the method... at least it didn't get inside of it.
>
> >> Let me know what's next. I can actually give you the account info and you
> >> can try run this from your development.
>
> >> DA.
>

> >> On Thu, Sep 23, 2010 at 2:56 PM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
> >>> Have you tried order approving? Did it called MakeOrder then?

> >>> On Sep 23, 2010 9:21 PM, "Dmitry Andrejev" <dandre...@gmail.com> wrote:
> >>> > Hi Alex,
>
> >>> > I have ran some tests on 5.1.x (5.1.1-B1).
>
> >>> > like we need some work.
>
> >>> > For some reason we never got to "MakeOrder" with USPS. See part of the
> >>> DEBUG
> >>> > occurred during Ship Order action.
>
> >>> > Let me know if you want access to my test site.
>
> >>> > DA.
>
> >>> > On Wed, Sep 22, 2010 at 1:54 PM, Alexander Obuhovich <

> >>> aik.b...@gmail.com>wrote:

>  usps_to_sqe_incommerce_v2.patch
> 29KViewDownload