Upgrade adodb time library to fix several warnings in PHP5.3

70 views
Skip to first unread message

Alexander Obuhovich

unread,
Mar 16, 2010, 8:02:46 AM3/16/10
to In-Portal Development
We have several warnings
PHP5 Depricated: mktime() [function.mktime]: The is_dst parameter is deprecated in \core\kernel\utility\adodb-time.inc.php  on line 143
PHP5 Depricated: gmmktime() [function.gmmktime]: The is_dst parameter is deprecated in \core\kernel\utility\adodb-time.inc.php on line 143

when date formatter converts dates from user input to timestamps.

Maybe there is a new adodb time library version, that have fixed this issue.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

Dmitry Andrejev

unread,
Mar 16, 2010, 8:30:57 PM3/16/10
to in-por...@googlegroups.com
Here is a link to the latest ADODB downloads



To be honest I doubt they have it addressed in their latest release.


DA.

Dmitry Andrejev

unread,
Mar 25, 2010, 2:23:28 AM3/25/10
to in-por...@googlegroups.com
Any idea on this Alex?

DA.

Alexander Obuhovich

unread,
Mar 25, 2010, 4:38:23 PM3/25/10
to in-por...@googlegroups.com
Latest downloadable version is 0.30, we are using 0.21. I've checked, that same error exists in latest version too. So at this point we cannot fix this.

To unsubscribe from this group, send email to in-portal-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.

Dmitry Andrejev

unread,
Mar 26, 2010, 11:18:08 AM3/26/10
to in-por...@googlegroups.com
is_dst

This parameter can be set to 1 if the time is during daylight savings time (DST), 0 if it is not, or -1 (the default) if it is unknown whether the time is within daylight savings time or not. If it's unknown, PHP tries to figure it out itself. This can cause unexpected (but not incorrect) results. Some times are invalid if DST is enabled on the system PHP is running on or is_dst is set to 1. If DST is enabled in e.g. 2:00, all times between 2:00 and 3:00 are invalid and mktime() returns an undefined (usually negative) value. Some systems (e.g. Solaris 8) enable DST at midnight so time 0:30 of the day when DST is enabled is evaluated as 23:30 of the previous day.

Note: As of PHP 5.1.0, this parameter became deprecated. As a result, the new timezone handling features should be used instead. 


Should do this when we'll be converting to PHP 5?

DA.

Alexander Obuhovich

unread,
Mar 26, 2010, 3:41:26 PM3/26/10
to in-por...@googlegroups.com
We don't change that adodb time library code, to fix it bugs. We of course could research what that new timezone handling method is, but while still using PHP4 we can't proceed with this further.

Alexander Obuhovich

unread,
Jan 25, 2011, 5:32:33 AM1/25/11
to in-por...@googlegroups.com
I've finally was able to fix it.


Ready for testing.
is_dst_warning_fix_in_adodb_library.patch

Dmitry A.

unread,
Jan 28, 2011, 8:14:09 AM1/28/11
to in-por...@googlegroups.com
Thanks Alex.

Patch tested good!


DA
Reply all
Reply to author
Forward
0 new messages