Inappropriate "eval" usage in kBase::makeClass method (optimization)

[Alexander Obuhovich]

Method kBase::makeClass is calling ref_call_user_func_array no matter if he has only class name or class name + constructor arguments passed. This slows downs the things a little bit. I propose to use code, mentioned above, that was called from kFactory class to optimize things.

if ( func_num_args() == 1 ) {
    $class = new $real_class();
}
else {
    $func_args = func_get_args();
    $pseudo_class = array_shift($func_args);
    $class =& ref_call_user_func_array( Array ($real_class,'makeClass'), $func_args );
}

--
Best Regards,

http://www.in-portal.org
http://www.alex-time.com

[Alexander Obuhovich]

Also kDBLIst class constructor during filter creation calls makeClass 13 times, but there are only two class types it creates, so we could create two classes and just clone them to create other fiters. Here is problematic code:

$filters = $this->getFilterStructure();

foreach ($filters as $filter_params) {
    $filter =& $this->$filter_params['type'];
    $filter[ $filter_params['class'] ] =& $this->Application->makeClass('kMultipleFilter', $filter_params['join_using']);

[Dmitry A.]

Thanks Alex,

Okay, do you think we should include this improvement in 5.0.2 or
5.1.0 release?

DA.

[Alexander Obuhovich]

Sure, why not.

--

You received this message because you are subscribed to the Google Groups "In-Portal Development" group.
To post to this group, send email to in-por...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-de...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-dev?hl=en.

[Alexander Obuhovich]

I've created corresponding task: http://tracker.in-portal.org/view.php?id=475 (0000475: Inappropriate "eval" usage in kBase::makeClass method).