Table "Widgets" isn't listed in "custom/install/remove_schema.sql" file

[Alexander Obuhovich]

Table "Widgets" isn't listed in "custom/install/remove_schema.sql" file, which results to sql error, when re-install installer option is used. Same for SiteDomains table (in 5.1.0 release).

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Dmitry A.]

To be honest I have noticed that before, but I think it should NOT be
removed since Widgets is a custom demo sample unit.

The same way we should consider adding all custom tables to remove SQL
files.

SiteDomains yes it's definitely should be in that remove_schema
thought...

Do you agree with me?

DA.

[Alexander Obuhovich]

I disagree. All module tables, that are created by install_schema.sql file of that module must be deleted in remove_schema.sql. If we don't do so as you propose, then we will get fatal error about duplicate widget table. And "Re-install" option assumes, that you don't need all that data after process is done.

> http://www.in-portal.comhttp://www.alex-time.com

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Yes, I do understand, I am just a bit concerned about the case when
all Custom structure/data can be gone...

By all you mean even the ones were added during the custom work?

DA.

> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>

[Alexander Obuhovich]

Currently we don't have uninstall option for each module separately. Only way is to drop all the database, which "re-install" option of installer does. File "remove_schema.sql" is to ensure, that no other non in-portal related tables (like wordpress, openx) won't be dropped as well.

Word "custom" in module name isn't some sort of special indicator for anything. Starting from 5.0.2 version developers could name modules like "in-*" and starting form 5.1.0 anything places inside "modules" folder is module. If site administrator selects "Re-install" option, then it's ready to the fact, that all data should be deleted.

It's surprising me a lot, that you don't share that concept. Module "In-News" was also a custom work maybe and he has "remove_schema.sql" file too, why "custom" is so different?

To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

There is also related issue:

ses_342291537_edit_PageContent type tables are NOT getting dropped
when reinstalling the In-Portal.

All ses_* tables.

DA.

On Mar 13, 7:31 pm, "Dmitry A." <dandre...@gmail.com> wrote:
> Yes, I do understand, I am just a bit concerned about the case when
> all Custom structure/data can be gone...
>
> By all you mean even the ones were added during the custom work?
>
> DA.
>
> On Mar 12, 2:15 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
>
>
>
> > I disagree. All module tables, that are created by install_schema.sql file
> > of that module must be deleted in remove_schema.sql. If we don't do so as

> > you propose, then we will get fatal error about duplicatewidgettable. And

[Alexander Obuhovich]

Temp tables are dropped, when session expired. Since you re-installed in-portal before that happened, then you got that tables. I think, that we could force temp table delete (but this will required all database table scan) to solve that.

To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry Andrejev]

I see no problem with scanning DB at that step AFTER we have dropped all our main tables. The SHOW TABLES will be super fast in most cases.

Ready for a task here?

DA.

[Alexander Obuhovich]

Sure.

[Dmitry A.]

Here is a task for it:

633: Drop all Custom and Session tables during the Reinstallation
process

http://tracker.in-portal.org/view.php?id=633

DA.

On Mar 19, 9:51 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> Sure.
>

> On Fri, Mar 19, 2010 at 4:45 PM, Dmitry Andrejev <dandre...@gmail.com>wrote:
>
>
>
>
>
> > I see no problem with scanning DB at that step AFTER we have dropped all
> > our main tables. The SHOW TABLES will be super fast in most cases.
>
> > Ready for a task here?
>
> > DA.
>

> > On Fri, Mar 19, 2010 at 5:53 AM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
> >> Temp tables are dropped, when session expired. Since you re-installed
> >> in-portal before that happened, then you got that tables. I think, that we
> >> could force temp table delete (but this will required all database table
> >> scan) to solve that.
>

> >>http://www.in-portal.com
> >>http://www.alex-time.com
>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "In-Portal Bugs Team" group.
> >> To post to this group, send email to in-port...@googlegroups.com.
> >> To unsubscribe from this group, send email to