In-Link Modify Link Bug

2 views
Skip to first unread message

Phil -- wbtc.fr --

unread,
Oct 28, 2010, 12:21:00 PM10/28/10
to in-port...@googlegroups.com
Hello guys,

in 511-b2,

- "link.modify" permission is active
- create a link
- go to "My links"
- click on "Modify" and update the link
- *Fatal Error: *mail error: header To is required in /home/sites/betainportal/web/5.1.1-beta2/full/core/kernel/utility/email_send.php on line 1093

As this is the default install, I bet there's a missing default parameter.

Phil.

Dmitry A.

unread,
Oct 28, 2010, 1:03:25 PM10/28/10
to In-Portal Bugs Team
Yes, I confirm there is a Fatal error.

The issue is there ONLY when we are trying to MODIFY a PENDING link
which NEVER has been approved yet. In other words it's MODIFY.PENDING
of the originally submitted pending link.


DA

Phil -- wbtc.fr --

unread,
Oct 28, 2010, 1:44:38 PM10/28/10
to in-port...@googlegroups.com
Additionnal info:
If a change permissions to "link.add.pending" I don't have this error message.
Then while it's an error message on MODIFY step, it doesn't act the same when I change the LINK.ADD permission


2010/10/28 Dmitry A. <dand...@gmail.com>
--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.


Dmitry A.

unread,
Oct 29, 2010, 2:46:13 PM10/29/10
to In-Portal Bugs Team
New task submitted for this bug:

910: Fatal error when Modifying Pending Link on Front-end

http://tracker.in-portal.org/view.php?id=910

DA

On Oct 28, 12:44 pm, "Phil -- wbtc.fr --" <p...@wbtc.fr> wrote:
> Additionnal info:
> If a change permissions to "link.add.pending" I don't have this error
> message.
> Then while it's an error message on MODIFY step, it doesn't act the same
> when I change the LINK.ADD permission
>
> 2010/10/28 Dmitry A. <dandre...@gmail.com>
>
>
>
> > Yes, I confirm there is a Fatal error.
>
> > The issue is there ONLY when we are trying to MODIFY a PENDING link
> > which NEVER has been approved yet. In other words it's MODIFY.PENDING
> > of the originally submitted pending link.
>
> > DA
>
> > On Oct 28, 11:21 am, "Phil -- wbtc.fr --" <p...@wbtc.fr> wrote:
> > > Hello guys,
>
> > > in 511-b2,
>
> > > - "link.modify" permission is active
> > > - create a link
> > > - go to "My links"
> > > - click on "Modify" and update the link
> > > - *Fatal Error: *mail error: header To is required in
>
> > /home/sites/betainportal/web/5.1.1-beta2/full/core/kernel/utility/email_sen
> > d.php
> > > on line 1093
>
> > > As this is the default install, I bet there's a missing default
> > parameter.
>
> > > Phil.
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "In-Portal Bugs Team" group.
> > To post to this group, send email to in-port...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>
> > .

Alexander Obuhovich

unread,
Oct 31, 2010, 9:27:53 AM10/31/10
to in-port...@googlegroups.com
Synopsis:

Before In-Portal 5.1.0 release we have this behavior:
1. field ModifiedById of category items were always set, even after initial category item creation (admin or suggest form).
2. when sending email event and email was missing, then admin email was used.

After In-Portal 5.1.0 release behavior was changed to:
1. set ModifiedById field only, when some of the fields where changed
2. don't use admin's email as fallback email for all cases

What happened:
When user opened modify form of newly added link and pressed "Modify" button without changing any fields, then ModifiedById field was not changed, but attempt was made to get user's email (from that field), who changed that link to send notification to it. That all resulted to email email event recipient email.


Strange, but I thought, that we should inform owner of link about changes to it's record, not user, who actually changes it.


To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.




--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com
link_modify_without_changing_it_gives_fatal_error.patch

Phil -- wbtc.fr --

unread,
Oct 31, 2010, 4:21:00 PM10/31/10
to in-port...@googlegroups.com
thanks for detail and fast patch release !

2010/10/31 Alexander Obuhovich <aik....@gmail.com>

Dmitry A.

unread,
Nov 1, 2010, 11:08:50 AM11/1/10
to In-Portal Bugs Team
Patch tested good and can be committed to 5.1.1 RC1

DA

On Oct 31, 3:21 pm, "Phil -- wbtc.fr --" <p...@wbtc.fr> wrote:
> thanks for detail and fast patch release !
>
> 2010/10/31 Alexander Obuhovich <aik.b...@gmail.com>
>
>
>
> > Synopsis:
>
> > Before In-Portal 5.1.0 release we have this behavior:
> > 1. field ModifiedById of category items were always set, even after initial
> > category item creation (admin or suggest form).
> > 2. when sending email event and email was missing, then admin email was
> > used.
>
> > After In-Portal 5.1.0 release behavior was changed to:
> > 1. set ModifiedById field only, when some of the fields where changed
> > 2. don't use admin's email as fallback email for all cases
>
> > What happened:
> > When user opened modify form of newly added link and pressed "Modify"
> > button without changing any fields, then ModifiedById field was not changed,
> > but attempt was made to get user's email (from that field), who changed that
> > link to send notification to it. That all resulted to email email event
> > recipient email.
>
> > Strange, but I thought, that we should inform owner of link about changes
> > to it's record, not user, who actually changes it.
>
> > Best Regards,
>
> >http://www.in-portal.com
> >http://www.alex-time.com
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "In-Portal Bugs Team" group.
> > To post to this group, send email to in-port...@googlegroups.com.
> > To unsubscribe from this group, send email to
Reply all
Reply to author
Forward
0 new messages