Forbidden URL after adding Poll Comment in In-Bulletin [5.1.1-B2]

[Dmitry A.]

Hi guys,


I think I have found a little bug with Adding Poll Comments with Mod-
Rewrite enabled.

After adding a comment I am getting redirect to a Forbidden page. Just
to remind that Adding the Comment and redirects are done with Ajax and
I think issue is related to the fact that system tries to deal with
this .eml templates by adding .HTML to the end and then doing the
Redirect.

index.php?env=-in-bulletin/elements/content_boxes/
add_poll_comment.elm:m0-1-1-3-s-:poll\-comment----OnCreate:poll-1----
&height=480&width=480&random=1288635201048

In results I am getting Redirect to

/in-bulletin/elements/content_boxes/add_poll_comment.elm.html?
height=480&width=480&random=1288635201048&env=poll%5C-
comment----:poll-1----


Somehow I need to skip this redirect.


DA

[Alexander Obuhovich]

If this is really the case, then redirect should be done with __NO_REWRITE__="1" option, set as redirect parameter from that OnCreate event, while on Front-end.

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Alexander Obuhovich]

Here you go. Seems, that "showCallback" ThickBox parameter wasn't used at all. You should be using "onDataReceived" parameter instead.

Please create the task then.

[Dmitry A.]

Thanks, but I can't apply the 1st patch - doesn't merge.

DA

On Nov 13, 5:25 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> Here you go. Seems, that "showCallback" ThickBox parameter wasn't used at
> all. You should be using "onDataReceived" parameter instead.
>
> Please create the task then.
>

> On Mon, Nov 1, 2010 at 8:47 PM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
>
>
>
>
>
>
>
>
> > If this is really the case, then redirect should be done with *
> > __NO_REWRITE__="1"* option, set as redirect parameter from that OnCreate
> > event, while on Front-end.

>
> > On Mon, Nov 1, 2010 at 8:25 PM, Dmitry A. <dandre...@gmail.com> wrote:
>
> >> Hi guys,
>
> >> I think I have found a little bug with Adding Poll Comments with Mod-
> >> Rewrite enabled.
>
> >> After adding a comment I am getting redirect to a Forbidden page. Just
> >> to remind that Adding the Comment and redirects are done with Ajax and
> >> I think issue is related to the fact that system tries to deal with
> >> this .eml templates by adding .HTML to the end and then doing the
> >> Redirect.
>
> >> index.php?env=-in-bulletin/elements/content_boxes/
> >> add_poll_comment.elm:m0-1-1-3-s-:poll\-comment----OnCreate:poll-1----
> >> &height=480&width=480&random=1288635201048
>
> >> In results I am getting Redirect to
>
> >> /in-bulletin/elements/content_boxes/add_poll_comment.elm.html?
> >> height=480&width=480&random=1288635201048&env=poll%5C-
> >> comment----:poll-1----
>
> >> Somehow I need to skip this redirect.
>
> >> DA
>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "In-Portal Bugs Team" group.
> >> To post to this group, send email to in-port...@googlegroups.com.
> >> To unsubscribe from this group, send email to

> >> in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>
> >> .

> >> For more options, visit this group at
> >>http://groups.google.com/group/in-portal-bugs?hl=en.
>
> > --
> > Best Regards,
>
> >http://www.in-portal.com
> >http://www.alex-time.com
>
> --
> Best Regards,
>
> http://www.in-portal.comhttp://www.alex-time.com
>

>  poll_redirect_fix_themes.patch
> 5KViewDownload
>
>  poll_redirect_fix_modules.patch
> < 1KViewDownload

[Alexander Obuhovich]

Do it manually or apply directly to the "advanced" theme and "in-bulletin" module (look in file patchs in the patch).

To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry Andrejev]

Applied the patch and tested, but still have the same problem when not getting properly redirected within TB modal window to Comments List (as expected and worked before).

Please run the test with DEBUG off and MOD-REWRITE on.

DA

Best regards,

Dmitry A.

[Dmitry A.]

By the way, here is a task for this bug:

923: Redirect to Poll Comments List isn't working after submitting a
Comment

http://tracker.in-portal.org/view.php?id=923

DA

On Nov 13, 2:25 pm, Dmitry Andrejev <dandre...@gmail.com> wrote:
> Applied the patch and tested, but still have the same problem when not
> getting properly redirected within TB modal window to Comments List (as
> expected and worked before).
>
> Please run the test with DEBUG off and MOD-REWRITE on.
>
> DA
>

> On Sat, Nov 13, 2010 at 12:49 PM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
>
>
>
>
>
>
>
>
> > Do it manually or apply directly to the "advanced" theme and "in-bulletin"
> > module (look in file patchs in the patch).
>

> Best regards,
>
> Dmitry A.

[Alexander Obuhovich]

If this worked before, then please find it somewhere working, since on http://beta.in-portal.org none of admins (5.1.0 or less) are working properly for me have an ability to at least test it.

[Dmitry Andrejev]

1. Admins on Beta.in-portal.org can be used now.

2. Strange enough I have tested this on at least 3 pre 5.1.0 release with the same results. Looks like it's been like that since 5.0.0 (smallest I have tested is 5.0.1)

DA

[Alexander Obuhovich]

Then it's never worked, please at least tell in which version that all stuff ever worked. I suppose you should track changed in "thickbox.js" file in "advanced" theme (which was called "default" in pre 5.0.0 releases). Since at some point somebody commented-out that "onAfterShow" callback usage in "thickbox.js" file and it all stopped working.

That same part is commented out in admin version of "thickbox.js" too.

[Dmitry Andrejev]

I believe it worked in In-Portal 4.3.9.

To be honest I haven't heard about any onAfterShow changes in thickbox.js.

DA

[Dmitry Andrejev]

No, actually I am wrong - I have Polls only in 5.0.0 version which VERY early version of In-Portal 5.

I am still checking if it worked back then.

DA

[Dmitry Andrejev]

Sorry, your patch works very well with exception that it couldn't be applies as easy as others you provided before.

I had double and triple checked and looks like Tortoise SVN client has messed up things for me a bit. In any case task will be marked as TESTED and can be committed (please do) and included in 5.1.1 as planned.

Thanks.

DA

[Alexander Obuhovich]

Also I've just noticed, that there was no need for passing __NO_REWRITE__ parameter to url. Everything worked even without it and even in mod-rewrite mode.