Auto-redirect from non-mod-rewrite url becomes very unstable

2 views
Skip to first unread message

Alexander Obuhovich

unread,
Aug 14, 2010, 9:51:12 AM8/14/10
to In-Portal Bugs
We have invented new feature in 5.1.0 release. It works this way: when someone visits page using url like /index.php?env=... and mod-rewrite is turned on, then he got redirected to same page, but with correct mod-rewrited url.

Seems quite harmless, but lately it became quite a problem:
  • unable to delete files uploaded via flash uploader (on front-end)
  • I always got top menu instead of sub-menus (on front-end)
I propose we disable it for now and think about it some time later, but before 5.2.0 release.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

Alexander Obuhovich

unread,
Aug 14, 2010, 10:01:17 AM8/14/10
to In-Portal Bugs
disable_redirect_from_non_rewrite_urls.patch

Alexander Obuhovich

unread,
Aug 20, 2010, 5:32:05 PM8/20/10
to In-Portal Bugs
I have an idea about how to deal with described problem.

Our site won't just create non-mod-rewrite urls, when mod-rewrite is enabled. So when we see non-mod-rewrited url, the it was made on purpose.

At the end, when HTTP_REFFERER is our site, then don't perform any url conversions. When google has old style link, then refferer would be it's site and proper redirect will be made.

Dmitry Andrejev

unread,
Aug 21, 2010, 4:44:17 AM8/21/10
to in-port...@googlegroups.com
Hi Alex,
 
I support your idea - I belive it will work just fine.
 
 
DA.

 

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

Alexander Obuhovich

unread,
Aug 21, 2010, 11:56:50 AM8/21/10
to in-port...@googlegroups.com
I was able to fix problem without disabling whole automatic redirect stuff.

Wasn't easy to fix, since I had to check http referer belongs not only to our site (in http or https), but also if it belongs to one of our site domains. Cross-site-domain links should also work too.

Task updated with new patches.
redirect_to_rewrited_url_fix_modules.patch
redirect_to_rewrited_url_fix_core.patch
Reply all
Reply to author
Forward
0 new messages