Some in-commerce prefixes doesnt use proper decimal fields

[Nikita]

I have found that in project Masai, table AffiliatePlansBrackets,
field Percent uses DECIMAL(3,2) which would allow to save only numbers
below 10 (9.99 etc), sa far as 10.00 is out of range already. Seems
that standards for decimal fields have changed since this unit was
added.

[Dmitry Andrejev]

Thanks for reporting Nikita!

Here is something on the web regarding this too - http://stackoverflow.com/questions/1523173/decimal3-2-values-in-mysql-are-always-9-99

Are you able to adjust it and provide a patch here? I would say make it as it's for all Price/OrderTotal fields Decimal(10,4)

DA

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

--

Best regards,

Dmitry A.

[Alexander Obuhovich]

I recall, that we had such problem before with order fields in In-Commerce module, but we've fixed it. I guess due less frequent usage of Affiliate functionality it wasn't noticed in time.

Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[asd]

Patch attached.

Dmitry Andrejev wrote:
> Thanks for reporting Nikita!
>
> Here is something on the web regarding this too
> - http://stackoverflow.com/questions/1523173/decimal3-2-values-in-mysql-are-always-9-99
>
> Are you able to adjust it and provide a patch here? I would say make

> it as it's for all Price/OrderTotal fields* Decimal(10,4)*

>
>
> DA
>
>
> On Thu, Mar 3, 2011 at 9:58 AM, Nikita <ingu...@gmail.com
> <mailto:ingu...@gmail.com>> wrote:
>
> I have found that in project Masai, table AffiliatePlansBrackets,
> field Percent uses DECIMAL(3,2) which would allow to save only numbers
> below 10 (9.99 etc), sa far as 10.00 is out of range already. Seems
> that standards for decimal fields have changed since this unit was
> added.
>
> --
> You received this message because you are subscribed to the Google
> Groups "In-Portal Bugs Team" group.
> To post to this group, send email to
> in-port...@googlegroups.com

> <mailto:in-port...@googlegroups.com>.

> To unsubscribe from this group, send email to
> in-portal-bug...@googlegroups.com

> <mailto:in-portal-bugs%2Bunsu...@googlegroups.com>.

[Dmitry A.]

Hi Nikita,

Thanks for the update!

Actually, we need to create a patch in proper patch format for In-Portal

For that you need to:

1. checkout In-Portal from SVN

2. all proper files (ie. install_schema.sql, upgrades.sql)

3. run your SVN client and do Create Patch on the changed files.

Make sense? Please give it another shot!

DA

[Dmitry A.]

Also, it would make sense to check ALL current DB fields for the same issue.

Here is a new task:

1010: Check all DECIMAL Database Fields for Correct Definitions

http://tracker.in-portal.org/view.php?id=1010

DA