Language system is not using available LanguageId when new language is added

[Dmitry A.]

Hi guys,

A minor new bug found in 5.0.x and 5.1.x development branches.

In some cases when I have 3 Languages, ie - English, Russian, German
and then I delete Russian. My next added language will have ID of 4
since the following method is used:

SELECT MAX(LanguageId)
FROM Language
LIMIT 0,1

keeping empty (open for usage) ID 2 from old Russian. In a perfect
world it would be great to reuse them so we don't end up with adding
more and more lN_ Fields to ALL tables...


Here is a task for it:

713: Language system is not using available LanguageId when new
language is added

http://tracker.in-portal.org/view.php?id=713

DA.

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Phil -- wbtc.fr --]

Hello Dmitry,

I'd like to say it's better to have a new lang ID for any new language as there's probably a russian content on website under ID 2 (example: product_name_l2), then your new lang will display russian text until you have time to translate all items again.

Also on import/export, if I want to retrieve a catalog backup, I'll write russian words for items in your new language because they have the same ID. In other word, you break the ability to reuse all backups before the lang change.

P.

2010/4/26 Dmitry A. <dand...@gmail.com>

[Dmitry A.]

Phil,

1. The reason why we do NOT delete the Language specific content with
deletion of the language is in case you (admin) deleted your language
accidentally and by Adding a New one (it will take the EMPTY) you can
always go back. Sounds like we SHOULD have Ok/Cancel dialog with full
explanation when we try deleting a Language - Would you like to delete
all Language specific content as well. Click "Ok" to confirm, or click
"Cancel" just to delete the Language.

2. Sorry, a I am a bit confused here - can you please clarify more.


Thanks.

On Apr 26, 6:35 am, "Phil -- wbtc.fr --" <p...@wbtc.fr> wrote:
> Hello Dmitry,
>
> I'd like to say it's better to have a new lang ID for any new language as
> there's probably a russian content on website under ID 2 (example:
> product_name_l2), then your new lang will display russian text until you
> have time to translate all items again.
>
> Also on import/export, if I want to retrieve a catalog backup, I'll write
> russian words for items in your new language because they have the same ID.
> In other word, you break the ability to reuse all backups before the lang
> change.
>
> P.
>

> 2010/4/26 Dmitry A. <dandre...@gmail.com>

>
>
>
>
>
> > Hi guys,
>
> > A minor new bug found in 5.0.x and 5.1.x development branches.
>
> > In some cases when I have 3 Languages, ie - English, Russian, German
> > and then I delete Russian. My next added language will have ID of 4
> > since the following method is used:
>
> >  SELECT MAX(LanguageId)
> >    FROM Language
> >    LIMIT 0,1
>
> > keeping empty (open for usage) ID 2 from old Russian. In a perfect
> > world it would be great to reuse them so we don't end up with adding
> > more and more lN_ Fields to ALL tables...
>
> > Here is a task for it:
>
> > 713: Language system is not using available LanguageId when new
> > language is added
>
> >http://tracker.in-portal.org/view.php?id=713
>
> > DA.
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "In-Portal Bugs Team" group.
> > To post to this group, send email to in-port...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>
> > .

> > For more options, visit this group at
> >http://groups.google.com/group/in-portal-bugs?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
> To post to this group, send email to in-port...@googlegroups.com.
> To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

> For more options, visit this group athttp://groups.google.com/group/in-portal-bugs?hl=en.

[Phil -- wbtc.fr --]

Dmitry,

1- I don't get you, actually we delete language specific content or not?

2- If I want to backup my catalog, I'll have all languages specific contents linked to their lang ID, in the backup it appears like this: item_l1 (for lang 1), item_l2 (for lang 2) and so on. If I want to import again my catalog (for whatever reason), it'll insert content for lang 2 in the right place, but it'll belong to another language if you have changed a lang pack in the meantime.

p.

2010/4/26 Dmitry A. <dand...@gmail.com>

[Alexander Obuhovich]

I agree with Phil on that backup restore thing.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Dmitry Andrejev]

The problem is that this whole part with Language deletion affects multiple places so we need to decided what to do here.

DA.

[Phil -- wbtc.fr --]

Dmitry,

I'd ask a question about your first message: why would we need to "economize" lang ID? They would probabaly not be greater than 10 on all the website life, is it a problem? Also, user would probably need to reuse a previous disabled language, this will create an -horrible- mess in all our configurations...

p.

2010/4/28 Dmitry Andrejev <dand...@gmail.com>

[Alexander Obuhovich]

I propose to do nothing based on all posts of this discussion. We can also keep translations of email events and phrases of deleted language (if needed).

[Dmitry V. Andrejev]

Okay, I agree - we can just leave everything as is now.

About deletion Events and Phrases when Language is deleted - I would make no changes here too for now.

-- 
With best regards,

Dmitry V. Andrejev