Email event translation not being validated before saving

[Alexander Obuhovich]

We have various (around 130) emails (email events), that could be sent throughout the system, e.g. after user registration, order submit, etc.

When administrator, during email translation editing, accidentally damages one or more In-Portal tags in it, then such email won't be sent at all.

Even more, it will raise Fatal Error and PHP code after email sending won't be executed.

For example, when error is in ORDER.SUBMIT email event translation, then user's order stays in "Incomplete" status and won't move to "Pending" status, even, when it's payment was successful.

I propose we validate email event translation before allowing it to be saved back into database (by NParser::CompileRaw method). I don't think, that we should output fancy error messages, like NParser does. We could just show, that there are a "tag syntax error" in translation.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Phil -- wbtc.fr --]

good idea, and more generally, it's weird to have blocking error
messages in admin, while e-mail are just an additionnal info for order
processing.

2010/5/22 Alexander Obuhovich <aik....@gmail.com>:

[Alexander Obuhovich]

Didn't understood a bit about blocking error and additional processing.

[Phil -- wbtc.fr --]

I meant that passing an order in another state, manually or
automatically, is a business action, involving payement/goods
sending/any action about the business, while sending e-mails are just
the info about these ctions. In other words, e-mails are no as
important as the action itself, but if we have a problem with emails,
then the action itself is stopped.

My though is to say that it shouldn't act like this, but rather
display a warning... Is there any other case where could block a
process? And what's your thought on this?

2010/5/22 Alexander Obuhovich <aik....@gmail.com>:

[Alexander Obuhovich]

Usually email is sent after all is done, but order processing is a bit complicated and it is sent in the middle.

After all this years somebody managed to broke down email event translation. When mine proposed check for tag syntax will be implemented, then no such problem should be at all.

[Phil -- wbtc.fr --]

anyway your proposal is a good stuff, and I'd like to have many other
field-checkers like this to make the software as intuitive as possible
:)

2010/5/22 Alexander Obuhovich <aik....@gmail.com>:

[Alexander Obuhovich]

Task: http://tracker.in-portal.org/view.php?id=822

[Dmitry A.]

Patch is ready for testing.

Cheers!