Branch: refs/heads/master
Home: https://github.com/ibus/ibus
Commit: ee6abd76f7b0f0fc8e1a8b6964f4d8216a3b6618
https://github.com/ibus/ibus/commit/ee6abd76f7b0f0fc8e1a8b6964f4d8216...
Author: Yusuke Sato <yusu...@chromium.org>
Date: 2011-01-15 (Sat, 15 Jan 2011)
Changed paths:
M bus/engineproxy.c
M bus/factoryproxy.c
M bus/panelproxy.c
Log Message:
-----------
Set correct g-flags to proxy objects.
This change is similar to https://github.com/ibus/ibus/commit/19247aac5a348185a0e180f254ab3858c....
The flag can prevent unnecessary communications between ibus-daemon and e.g. engines like this:
$ . ~/.config/ibus/bus/*-unix-0 ; dbus-monitor --address $IBUS_ADDRESS 2>&1 | tee /tmp/ibus.log
...
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=3 path=/org/freedesktop/IBus/Factory; interface=org.freedesktop.IBus.Factory; member=CreateEngine
string "mozc-jp"
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=3
object path "/org/freedesktop/IBus/Engine/1"
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=4 path=/org/freedesktop/IBus/Engine/1; interface=org.freedesktop.DBus.Properties; member=GetAll
string "org.freedesktop.IBus.Engine"
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=4
array [
]
Calling an engine's org.freedesktop.DBus.Properties.GetAll method when the engine is created is unnecessary for ibus-daemon, while it's not harmful though.
BUG=none
TEST=verified using dbus-monitor that ibus-daemon does not call GetAll anymore.
Review URL: http://codereview.appspot.com/4036041