Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
ee6abd: Set correct g-flags to proxy objects.
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  1 message - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
nore...@github.com  
View profile  
 More options Jan 15 2011, 9:33 pm
From: nore...@github.com
Date: Sat, 15 Jan 2011 18:33:44 -0800
Local: Sat, Jan 15 2011 9:33 pm
Subject: [ibus/ibus] ee6abd: Set correct g-flags to proxy objects.
Branch: refs/heads/master
Home:   https://github.com/ibus/ibus

Commit: ee6abd76f7b0f0fc8e1a8b6964f4d8216a3b6618
    https://github.com/ibus/ibus/commit/ee6abd76f7b0f0fc8e1a8b6964f4d8216...
Author: Yusuke Sato <yusu...@chromium.org>
Date:   2011-01-15 (Sat, 15 Jan 2011)

Changed paths:
  M bus/engineproxy.c
  M bus/factoryproxy.c
  M bus/panelproxy.c

Log Message:
-----------
Set correct g-flags to proxy objects.

This change is similar to https://github.com/ibus/ibus/commit/19247aac5a348185a0e180f254ab3858c....

The flag can prevent unnecessary communications between ibus-daemon and e.g. engines like this:

$ . ~/.config/ibus/bus/*-unix-0 ; dbus-monitor --address $IBUS_ADDRESS 2>&1 | tee /tmp/ibus.log
...
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=3 path=/org/freedesktop/IBus/Factory; interface=org.freedesktop.IBus.Factory; member=CreateEngine
   string "mozc-jp"
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=3
   object path "/org/freedesktop/IBus/Engine/1"
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=4 path=/org/freedesktop/IBus/Engine/1; interface=org.freedesktop.DBus.Properties; member=GetAll
   string "org.freedesktop.IBus.Engine"
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=4
   array [
   ]

Calling an engine's org.freedesktop.DBus.Properties.GetAll method when the engine is created is unnecessary for ibus-daemon, while it's not harmful though.

BUG=none
TEST=verified using dbus-monitor that ibus-daemon does not call GetAll anymore.

Review URL: http://codereview.appspot.com/4036041


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »