libpano SVN 1137 fails to build

[Jean-Luc Coulon (f5ibh)]

Hi,

I get the following:

[...]
/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-DHasJPEG -DHasPNG -DHasTIFF -DHasZLIB -D__Ansi__=1 -g -O2 -MT
PTDialogs.lo -MD -MP -MF .deps/PTDialogs.Tpo -c -o PTDialogs.lo
PTDialogs.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -DHasJPEG -DHasPNG -DHasTIFF
-DHasZLIB -D__Ansi__=1 -g -O2 -MT PTDialogs.lo -MD -MP -MF .deps/
PTDialogs.Tpo -c PTDialogs.c -fPIC -DPIC -o .libs/PTDialogs.o
In file included from PTDialogs.c:29:
sys_ansi.h:44: error: expected ‘)’ before ‘Owner’
sys_ansi.h:45: error: expected ‘)’ before ‘hDlg’
make[2]: *** [PTDialogs.lo] Error 1

I run Debian sid

Regards

Jean-Luc

[Jim Watters]

That was my doing. I got to run and will look at it in about 4 hours.
In the mean time, can you test changing the two functions in sys_ansi.h
I expect HWND is undefined.
void SetWindowOwner(PVOID Owner);
void CenterDialog(PVOID hDlg);

--
Jim Watters
http://photocreations.ca

[Jim Watters]

I have attached a patch. Does this work for you?
The two functions of question are exposed for use with GUI build of
libPano13 but are not reliant with the CMD version.

[Alex Romosan]

Jim Watters <jwat...@photocreations.ca> writes:

>> That was my doing. I got to run and will look at it in about 4 hours.
>> In the mean time, can you test changing the two functions in sys_ansi.h
>> I expect HWND is undefined.
>> void SetWindowOwner(PVOID Owner);
>> void CenterDialog(PVOID hDlg);
> I have attached a patch. Does this work for you?
> The two functions of question are exposed for use with GUI build of
> libPano13 but are not reliant with the CMD version.

shouldn't PVOID just be void* ?

--alex--

--
| I believe the moment is at hand when, by a paranoiac and active |
| advance of the mind, it will be possible (simultaneously with |
| automatism and other passive states) to systematize confusion |
| and thus to help to discredit completely the world of reality. |

[Jean-Luc Coulon (f5ibh)]

Le 08/11/2009 23:19:03, Jim Watters a écrit :
>Jim Watters wrote:

>>>
>>>
>> That was my doing. I got to run and will look at it in about 4
>> hours.
>> In the mean time, can you test changing the two functions in
>sys_ansi.h
>> I expect HWND is undefined.
>> void SetWindowOwner(PVOID Owner);
>> void CenterDialog(PVOID hDlg);
>I have attached a patch. Does this work for you?

I've the same error message with the patch applied

Regards

Jean-Luc

>The two functions of question are exposed for use with GUI build of
>libPano13 but are not reliant with the CMD version.
>
>--
>Jim Watters
>http://photocreations.ca
>
>

>--~--~---------~--~----~------------~-------~--~----~
>You received this message because you are subscribed to the Google
>Groups "hugin and other free panoramic software" group.
>A list of frequently asked questions is available at:
>http://wiki.panotools.org/Hugin_FAQ
>To post to this group, send email to hugi...@googlegroups.com
>To unsubscribe from this group, send email to
>hugin-ptx+...@googlegroups.com
>For more options, visit this group at
>http://groups.google.com/group/hugin-ptx
>-~----------~----~----~----~------~----~------~--~---
>
>

------texte cité en attachement "HWND.patch"------
>Index: sys_ansi.c
>===================================================================
>--- sys_ansi.c (revision 1137)
>+++ sys_ansi.c (working copy)
>@@ -25,8 +25,8 @@
> //------------------ Public functions required by filter.h
>-------------------------------
>
>
>-void SetWindowOwner(HWND Owner) {return;}
>-void CenterDialog(HWND hDlg) {return;}
>+void SetWindowOwner(PVOID Owner) {return;}
>+void CenterDialog(PVOID hDlg) {return;}
>
> void filter_main( TrformStr *TrPtr, struct size_Prefs *spref)
> {
>Index: sys_ansi.h
>===================================================================
>--- sys_ansi.h (revision 1137)
>+++ sys_ansi.h (working copy)
>@@ -41,8 +41,8 @@
>
> \
> return( FALSE );
>
>-void SetWindowOwner(HWND Owner);
>-void CenterDialog(HWND hDlg);
>+void SetWindowOwner(PVOID Owner);
>+void CenterDialog(PVOID hDlg);
>
> #define kSetRemapPrefs_dlg "REMAP"
> #define kSetRemapPrefs_InRect
> 350
>