Changes to panotools projects on Sourceforge, Mercurial repositories

47 views
Skip to first unread message

Bruno Postle

unread,
May 13, 2013, 5:01:37 PM5/13/13
to Hugin ptx, Panorama Tools software developers
Hi all, Sourceforge have 'upgraded' the panotools project on
sourceforge: http://sourceforge.net/projects/panotools/

Mercurial repositories have moved, you can now find the libpano13
code here:

hg clone http://hg.code.sf.net/p/panotools/libpano13

So if you have an existing checkout you can either rebase it by
editing the .hg/hgrc file, or just fetch a fresh one. The old
Mercurial repository will continue to exist, but is now read-only.

I took the opportunity to migrate the other panotools projects from
Subversion to Mercurial (hooray!), these are:

Panotools::Script - perl module for manipulating Hugin .pto projects

GIMP plugin - A GIMP panotools plugin, this needs to maintenance

ptfilter - Photoshop filters for panotools

MPRemap - Java moving panoramas remapping

If there is anything I'm missing, please let me know. e.g. I
haven't migrated the old libpano12 binary-compatible library - Does
anyone want this?

--
Bruno

___matthieu___

unread,
May 13, 2013, 7:45:14 PM5/13/13
to hugi...@googlegroups.com, Panorama Tools software developers
Hi Bruno,

In the process of having a build of Hugin on MacOSX 10.8 that is compatible with MacOSX 10.6, I found that libpano13 was using a symbol (___progname) that was not present on OSX 10.6.

I only found it in sys_compat_unix.c; I replaced the call from ___progname to getprogname() (which is defined in stdlib.h).
This enables the library to be used on 10.6 and 10.8 without problem.

Though, I do not know if my change produces the same output, it used (from what I found) only in file.c:panoPSDResourcesBlockWrite() and I do not know how to test it.

Is there any way to test it ? Is this change acceptable and/or can it lead to problems ?

I attach the diff to this post.

Matthieu
libpano13-___progname.diff

Bruno Postle

unread,
May 14, 2013, 2:59:22 PM5/14/13
to Hugin ptx, Panorama Tools software developers
On Mon 13-May-2013 at 16:45 -0700, ___matthieu___ wrote:
>
>In the process of having a build of Hugin on MacOSX 10.8 that is compatible
>with MacOSX 10.6, I found that libpano13 was using a symbol (___progname)
>that was not present on OSX 10.6.
>
>I only found it in sys_compat_unix.c; I replaced the call from ___progname
>to getprogname() (which is defined in stdlib.h).
>This enables the library to be used on 10.6 and 10.8 without problem.
>
>Though, I do not know if my change produces the same output, it used (from
>what I found) only in file.c:panoPSDResourcesBlockWrite() and I do not know
>how to test it.

Think this should only get called by PTtiff2psd, you could test it
by trying to join some TIFF files (created by Hugin) into a
multilayer PSD file:

PTtiff2psd pano_0001.tif pano_0002.tif pano_0003.tif

>Is there any way to test it ? Is this change acceptable and/or can it lead
>to problems ?

It seems harmless so I committed it, thanks for contributing.

--
Bruno
Reply all
Reply to author
Forward
0 new messages