Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Making httplib2.Http instances pickleable. (issue 6506074)

Received: by 10.236.78.232 with SMTP id g68mr8569144yhe.3.1347903985519;
        Mon, 17 Sep 2012 10:46:25 -0700 (PDT)
X-BeenThere: httplib2-dev@googlegroups.com
Received: by 10.236.88.242 with SMTP id a78ls4042949yhf.6.gmail; Mon, 17 Sep
 2012 10:46:24 -0700 (PDT)
Received: by 10.236.136.202 with SMTP id w50mr8370283yhi.47.1347903984058;
        Mon, 17 Sep 2012 10:46:24 -0700 (PDT)
Received: by 10.236.136.202 with SMTP id w50mr8370281yhi.47.1347903984047;
        Mon, 17 Sep 2012 10:46:24 -0700 (PDT)
Return-Path: <37mFXUA0JDJc3F45I5M95N-8I7D19C.3FD8KKGC92T-45M7FF7C57IFLGJ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com>
Received: from mail-qc0-f199.google.com (mail-qc0-f199.google.com [209.85.216.199])
        by gmr-mx.google.com with ESMTPS id g28si2712204qcq.2.2012.09.17.10.46.23
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 17 Sep 2012 10:46:23 -0700 (PDT)
Received-SPF: pass (google.com: domain of 37mFXUA0JDJc3F45I5M95N-8I7D19C.3FD8KKGC92T-45M7FF7C57IFLGJ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.216.199 as permitted sender) client-ip=209.85.216.199;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 37mFXUA0JDJc3F45I5M95N-8I7D19C.3FD8KKGC92T-45M7FF7C57IFLGJ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.216.199 as permitted sender) smtp.mail=37mFXUA0JDJc3F45I5M95N-8I7D19C.3FD8KKGC92T-45M7FF7C57IFLGJ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com; dkim=pass header...@google.com
Received: by qcac1 with SMTP id c1so8442676qca.2
        for <httplib2-dev@googlegroups.com>; Mon, 17 Sep 2012 10:46:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
         :subject:from:to:cc:content-type;
        bh=CW8BRQ10ZZRD2edcklJCmaW1aT2y/+KKzNG3Pa54jBU=;
        b=itwSBisBsvAkSRMsExWAz70gyNbmmwGpz2Us0d34P1iDKDC3i7DSnXVW8aiyW+NyIr
         MV8GIy21JB8k7WSTpB4KdNC4daCG73xJvBTjxkoR03td7KckGPH9IOvbS3Rg/n1HC7WK
         ChhmGDtzmmPL66TO0qI/8dV3q6Q4dlSKTIjMn1SlA6COWIL7Jnn9veyIH8uPkfYNjNBM
         kCghVI/YLqDTbqP1/obnBoxJDoZ1A9mSqT5J1XXVA86u2I6aoI5I1M8GmOFybLxnkixH
         ojP75NI00HRDmknL6UuAHe9RN9sG6wFx93r43BlVX8uDpnPHt4Imwd8ZKkKGEMu1tFXw
         S/CA==
MIME-Version: 1.0
Received: by 10.58.19.99 with SMTP id d3mr2509821vee.32.1347903982913; Mon, 17
 Sep 2012 10:46:22 -0700 (PDT)
Reply-To: dher...@google.com, joe.grego...@gmail.com, jcgrego...@google.com, 
	httplib2-dev@googlegroups.com, re...@codereview-hr.appspotmail.com
Message-ID: <047d7b86c5ec17cc2d04c9e95...@google.com>
Date: Mon, 17 Sep 2012 17:46:22 +0000
Subject: Re: Making httplib2.Http instances pickleable. (issue 6506074)
From: jcgrego...@google.com
To: dher...@google.com, joe.grego...@gmail.com
Cc: httplib2-dev@googlegroups.com, re...@codereview-hr.appspotmail.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes


https://codereview.appspot.com/6506074/diff/14002/python3/httplib2/__init__.py
File python3/httplib2/__init__.py (right):

https://codereview.appspot.com/6506074/diff/14002/python3/httplib2/__init__.py#newcode801
python3/httplib2/__init__.py:801: def __init__(self, cache=None,
timeout=None, proxy_info=None,
Looks like defaulting to proxyinfo from environment never made it into
the code, even though that's what the doc comments say. Can you update
the proxy handling for Python 3 be the same as Python 2?

https://codereview.appspot.com/6506074/