PHP-FPM Patch for PHP 5.2.10 available (officially now)

[Michael Shadle]

Cross-post with the nginx mailing list, since a lot of nginx users use
PHP-FPM...

Andrei has changed the license so it will be compatible with PHP and I
am working to get it sponsored to either get into PECL or PHP itself.
In the meantime, I have taken over the website from him (he has been
too busy and has had to move on, thank you Andrei for your work :))
and I guess have officially become the owner of the project.

I do not know C, but I will be acting more as a facilitator, fund
raiser, and more or less project manager for the project until it may
become part of PHP core; at that point, there is no need for it to be
separate anymore.

That being said, anyone who would like to donate, or help keep the
PHP-FPM patches up to date when new PHP versions come out. I've
incremented the fpm version number this time as code has changed to
make it compatible with php 5.2.10, and we've had successful reports
with production deployments.

http://php-fpm.org/downloads/php-5.2.10-fpm-0.5.11.diff.gz

In the next week or so I'll be trying to straighten out the website so
it has English, Russian and other languages and will probably just be
a wiki since it doesn't really need to be more than that.
Documentation about the configuration file, "what is PHP-FPM?", how to
compile/patch it, etc. and try to organize it in a decent fashion for
the multiple languages...

If you've got any comments, etc. feel free to post them to the
highload-php-en mailing list, or email me directly. This is a one-time
notification to the nginx mailing list. :)

[fei]

OK---Everything is Ok!works Fine...Thanks a lot!

Posted at Nginx Forum: http://forum.nginx.org/read.php?3,3195,3200#msg-3200

[Jim Ohlstein]

mike Wrote:
-------------------------------------------------------

I hate to be technical but you versioned this as php-fpm-0.5.11
but the version is not updated in the patch itself (see lines 119
and 27700).

>
> In the next week or so I'll be trying to
> straighten out the website so
> it has English, Russian and other languages and
> will probably just be
> a wiki since it doesn't really need to be more
> than that.
> Documentation about the configuration file, "what
> is PHP-FPM?", how to
> compile/patch it, etc. and try to organize it in a
> decent fashion for
> the multiple languages...
>
> If you've got any comments, etc. feel free to post
> them to the
> highload-php-en mailing list, or email me
> directly. This is a one-time
> notification to the nginx mailing list. :)

Posted at Nginx Forum: http://forum.nginx.org/read.php?3,3195,3201#msg-3201

[Michael Shadle]

picky picky picky :P

ill fix that then! heh

[Jim Ohlstein]

Michael Shadle wrote:
> picky picky picky :P
Perhaps, but I think that consistency is important. You want it to show
correctly in phpinfo then the patch needs to be updated. So when you are
trying to provide technical support and ask what version of php-fpm do
you have installed you can get a correct answer. For that reason you
might want to consider re-versioning the patch as 0.5.12 so there's
absolutely no confusion.

Jim

[Michael Shadle]

I know, I fixed it after you said that.

Nah, I don't think it should be re-versioned again. When I was adding
the ChangeLog entry I was thinking to myself "wow, there really isn't
a huge change here other than a new contribution model and minor
adjustments to work with 5.2.10" - but Andrei made adjustments for
each version of PHP anyway, he only incremented the FPM portion when
it had a change.

So it was kind of a non-functional version increment anyway.

[Jim Ohlstein]

Michael Shadle wrote:
> I know, I fixed it after you said that.
>
> Nah, I don't think it should be re-versioned again. When I was adding
> the ChangeLog entry I was thinking to myself "wow, there really isn't
> a huge change here other than a new contribution model and minor
> adjustments to work with 5.2.10" - but Andrei made adjustments for
> each version of PHP anyway, he only incremented the FPM portion when
> it had a change.
>

Andrei incremented the version with *every* version of php supported.
See http://php-fpm.anight.org/changes.html

Each time the code is changed it should be re-versioned for consistency
sake. That way you know exactly what you're dealing with. Igor does that
with nginx. Look at http://nginx.net/CHANGES specifically at "Changes
with nginx 0.7.19". It was identical to 0.7.18 but when 0.7.18 was
compiled the headers showed 0.7.17. They were separated by only a matter
of a couple of hours and that was the only change.

Hey, it's your baby now, you can handle it how think is best. My opinion
is that it should be handled professionally. When a release is changed
that's a new minor version. Not all version changes require new
features, they can be bugfixes. This was a "bug" any way you look at it.

[bizhat]

Some one should create http://github.com/php-fpm for better community involvement.

Posted at Nginx Forum: http://forum.nginx.org/read.php?3,3195,3229#msg-3229

[Michael Shadle]

It's only a single patchfile and I'm waiting for word back from the PECL/PHP team. It may be irrelevant.

[Michael Shadle]

Wow, I did not notice that. I thought he only incremented it when he
had to make a change, like a libevent change.

I really screwed the pooch on that one :)

I promise only proper versioning for any future releases.

[Usu]

Thank you, it works like a charm :)