Hector: Add token support to get_range_slices (issue #410)

[horschi]

Hi everyone,

I'm interested in token support for range slices. Someone else already created a ticket for it: https://github.com/hector-client/hector/issues/410

I hacked together a patch that adds range support for Token->Token and Key->Token ranges (which is exactly what ThriftValidation.validateKeyRange allows). It basically adds a setTokens method to the existing setKeys:

    RangeSlicesQuery<K, N, V> setKeys(K start, K end);
+  RangeSlicesQuery<K, N, V> setTokens(K startKey, String startToken, String endToken);

Is there any chance to get token-support into the official client?

I'm open for any suggestions on how to improve the patch.  I could image that the range-iterator could use token support too. So feel free to criticise, I can take it :-)

Cheers,
Christian

[Nate McCall]

Yeah, if you want to fork, apply the patch, and send a pull request,
I'd take this. Thanks!

> --
> You received this message because you are subscribed to the Google Groups
> "hector-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to hector-dev+...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>